From: Arnd Bergmann <arnd@arndb.de>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, rjw@sisk.pl,
linus.walleij@stericsson.com, linux-sh@vger.kernel.org,
horms@verge.net.au, grant.likely@secretlab.ca, olof@lixom.net
Subject: Re: [PATCH] gpio: Emma Mobile GPIO driver V2
Date: Wed, 16 May 2012 12:09:03 +0000 [thread overview]
Message-ID: <201205161209.03985.arnd@arndb.de> (raw)
In-Reply-To: <CANqRtoSSEb9jwEmvbhBuyHp-9BfUSRabQzqjrrVGTFDP-AHutQ@mail.gmail.com>
On Wednesday 16 May 2012, Magnus Damm wrote:
> > irq_domain_add_legacy() exists for existing static ranges, which there is
> > really no reason to be adding in new board/platform support. You don't
> > have to worry about virq overlap since irq_create_mapping() already wraps
> > on top of irq_alloc_desc_xxx() for lookup.
>
> So I intentionally made use of the legacy domain in the non-DT case.
> This because I want to let the SoC code set the static IRQ ranges via
> platform data.
I think it's generally better to use just one code path for both cases,
if you need both DT and non-DT support, which means you would always
use irq_domain_add_legacy. Once you have the final patch to convert it
to DT, you can remove the legacy domain and just convert it to linear.
Arnd
next prev parent reply other threads:[~2012-05-16 12:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 15:43 [PATCH] gpio: Emma Mobile GPIO driver V2 Magnus Damm
2012-05-15 16:32 ` Joe Perches
2012-05-17 6:20 ` Magnus Damm
2012-05-16 7:11 ` Linus Walleij
2012-05-16 10:15 ` Magnus Damm
2012-05-16 11:25 ` Linus Walleij
2012-05-16 20:05 ` Rafael J. Wysocki
2012-05-16 22:22 ` Olof Johansson
2012-05-16 22:37 ` Rafael J. Wysocki
2012-05-16 22:54 ` Olof Johansson
2012-05-18 22:56 ` Grant Likely
2012-05-19 1:18 ` Olof Johansson
2012-05-19 1:44 ` Grant Likely
2012-05-19 2:27 ` Olof Johansson
2012-05-19 12:06 ` Rafael J. Wysocki
2012-05-16 7:29 ` Paul Mundt
2012-05-16 10:09 ` Magnus Damm
2012-05-16 12:09 ` Arnd Bergmann [this message]
2012-05-16 15:47 ` Magnus Damm
2012-05-17 0:41 ` Paul Mundt
2012-05-18 23:25 ` Grant Likely
2012-05-19 6:46 ` Paul Mundt
2012-05-19 20:05 ` Grant Likely
2012-05-18 22:57 ` Grant Likely
2012-05-19 2:13 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205161209.03985.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=horms@verge.net.au \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=olof@lixom.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox