From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
arve@android.com, Rebecca Schultz Zavin <rebecca@android.com>,
Jesper Juhl <jj@chaosbits.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Boyd <sboyd@codeaurora.org>,
Thomas Meyer <thomas@m3y3r.de>,
Andrew Morton <akpm@linux-foundation.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com
Subject: [PATCH 2/6] pstore/ram: Add console messages handling
Date: Wed, 16 May 2012 05:56:34 -0700 [thread overview]
Message-ID: <20120516125634.GB20475@lizard> (raw)
In-Reply-To: <20120516125330.GA15460@lizard>
This is all straightforward: we just use the last region for
console logging. If there's just one region, we fall-back to
the old behaviour: just a oops/dumps logging.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
fs/pstore/ram.c | 39 ++++++++++++++++++++++++++++++---------
1 file changed, 30 insertions(+), 9 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 9123cce..54213eb 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -63,6 +63,7 @@ MODULE_PARM_DESC(ramoops_ecc,
struct ramoops_context {
struct persistent_ram_zone **przs;
+ struct persistent_ram_zone *cprz;
phys_addr_t phys_addr;
unsigned long size;
size_t record_size;
@@ -70,6 +71,7 @@ struct ramoops_context {
bool ecc;
unsigned int count;
unsigned int max_count;
+ unsigned int max_dump_count;
unsigned int read_count;
struct pstore_info pstore;
};
@@ -92,16 +94,20 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type,
{
ssize_t size;
struct ramoops_context *cxt = psi->data;
- struct persistent_ram_zone *prz;
-
- if (cxt->read_count >= cxt->max_count)
- return -EINVAL;
+ struct persistent_ram_zone *prz = cxt->przs[cxt->read_count];
*id = cxt->read_count++;
- prz = cxt->przs[*id];
- /* Only supports dmesg output so far. */
- *type = PSTORE_TYPE_DMESG;
+ if (*id < cxt->max_dump_count && persistent_ram_old_size(prz)) {
+ *type = PSTORE_TYPE_DMESG;
+ } else if (*id < cxt->max_count) {
+ *type = PSTORE_TYPE_CONSOLE;
+ prz = cxt->cprz;
+ cxt->read_count = cxt->max_count;
+ } else {
+ return 0;
+ }
+
/* TODO(kees): Bogus time for the moment. */
time->tv_sec = 0;
time->tv_nsec = 0;
@@ -142,7 +148,12 @@ static int ramoops_pstore_write(enum pstore_type_id type,
struct persistent_ram_zone *prz = cxt->przs[cxt->count];
size_t hlen;
- /* Currently ramoops is designed to only store dmesg dumps. */
+ if (type == PSTORE_TYPE_CONSOLE) {
+ if (!cxt->cprz)
+ return -ENOMEM;
+ persistent_ram_write(cxt->cprz, cxt->pstore.buf, size);
+ }
+
if (type != PSTORE_TYPE_DMESG)
return -EINVAL;
@@ -170,7 +181,7 @@ static int ramoops_pstore_write(enum pstore_type_id type,
size = prz->buffer_size - hlen;
persistent_ram_write(prz, cxt->pstore.buf, size);
- cxt->count = (cxt->count + 1) % cxt->max_count;
+ cxt->count = (cxt->count + 1) % cxt->max_dump_count;
return 0;
}
@@ -264,6 +275,16 @@ static int __init ramoops_probe(struct platform_device *pdev)
}
}
+ /*
+ * The last zone is for TYPE_CONSOLE, unless we have only
+ * one, in which case we use it for oops/panic logging.
+ */
+ cxt->max_dump_count = cxt->max_count;
+ if (cxt->max_count > 1) {
+ cxt->max_dump_count--;
+ cxt->cprz = cxt->przs[cxt->max_count - 1];
+ }
+
cxt->pstore.data = cxt;
cxt->pstore.bufsize = cxt->przs[0]->buffer_size;
cxt->pstore.buf = kmalloc(cxt->pstore.bufsize, GFP_KERNEL);
--
1.7.9.2
next prev parent reply other threads:[~2012-05-16 12:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 12:53 [PATCH 0/6] Merge ram_console into pstore Anton Vorontsov
2012-05-16 12:56 ` [PATCH 1/6] pstore: Add console log messages support Anton Vorontsov
2012-05-16 16:49 ` Kees Cook
2012-05-16 22:33 ` Anton Vorontsov
2012-05-17 0:47 ` Anton Vorontsov
2012-05-16 12:56 ` Anton Vorontsov [this message]
2012-05-16 15:30 ` [PATCH 2/6] pstore/ram: Add console messages handling Shuah Khan
2012-05-16 22:20 ` Anton Vorontsov
2012-05-16 16:45 ` Kees Cook
2012-05-16 22:28 ` Anton Vorontsov
2012-05-16 12:56 ` [PATCH 3/6] pstore/ram_core: Silence some printks Anton Vorontsov
2012-05-16 12:56 ` [PATCH 4/6] pstore/ram: Add some more documentation and examples Anton Vorontsov
2012-05-16 15:28 ` Shuah Khan
2012-05-16 17:56 ` Colin Cross
2012-05-16 22:11 ` Anton Vorontsov
2012-05-16 22:25 ` Colin Cross
2012-05-16 12:57 ` [PATCH 5/6] staging/android: Remove ram_console driver Anton Vorontsov
2012-05-16 12:57 ` [PATCH 6/6] pstore/ram_core: Remove now unused code Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2012-05-17 8:37 [PATCH v2 0/6] Merge ram_console into pstore Anton Vorontsov
2012-05-17 8:40 ` [PATCH 2/6] pstore/ram: Add console messages handling Anton Vorontsov
2012-05-17 16:38 ` Kees Cook
2012-05-17 18:28 ` Colin Cross
2012-05-18 21:49 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516125634.GB20475@lizard \
--to=anton.vorontsov@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rebecca@android.com \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox