From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
Stephen Hemminger <shemminger@vyatta.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq
Date: Wed, 16 May 2012 12:53:32 -0700 [thread overview]
Message-ID: <20120516195332.GC21275@google.com> (raw)
In-Reply-To: <CA+55aFw-us7LnG-iq5EQmSDJ7xH9hiOMmCryAGobReko4LkVWg@mail.gmail.com>
On Wed, May 16, 2012 at 12:47:27PM -0700, Linus Torvalds wrote:
> On Wed, May 16, 2012 at 12:37 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> > + cancel_delayed_work_sync(&fd_timeout);
> > + cancel_delayed_work_sync(&fd_timer);
> > + destroy_workqueue(system_nrt_wq);
>
> Well, *that* doesn't look right.
>
> I think just a "flush_workqueue()" is in order.
System wqs shouldn't be flushed (nothing guarantees that flush will
finish in fixed amount of time). We probably should make that
explicit by whining when someone tries to flush one of the system wqs.
Here, the two cancel_delayed_work_sync() calls should be enough.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-16 19:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 7:36 [PATCH] floppy: convert to delayed work and single-thread wq Jiri Kosina
2012-05-16 14:57 ` Stephen Hemminger
2012-05-16 15:25 ` Linus Torvalds
2012-05-16 17:01 ` Tejun Heo
2012-05-16 19:37 ` Jiri Kosina
2012-05-16 19:43 ` Linus Torvalds
2012-05-16 19:47 ` Linus Torvalds
2012-05-16 19:51 ` Jiri Kosina
2012-05-16 19:53 ` Tejun Heo [this message]
2012-05-16 19:57 ` Jiri Kosina
2012-05-16 20:01 ` Tejun Heo
2012-05-16 20:24 ` Jiri Kosina
2012-05-16 20:29 ` Tejun Heo
2012-05-16 20:42 ` Linus Torvalds
2012-05-17 14:55 ` Tejun Heo
2012-05-17 15:03 ` Linus Torvalds
2012-05-17 15:06 ` Jiri Kosina
2012-05-17 15:09 ` Tejun Heo
2012-05-17 15:46 ` Jiri Kosina
2012-05-17 16:02 ` Tejun Heo
2012-05-16 20:44 ` Jiri Kosina
2012-05-17 15:06 ` Tejun Heo
2012-05-17 7:56 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516195332.GC21275@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox