From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760584Ab2EPTxi (ORCPT ); Wed, 16 May 2012 15:53:38 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:50596 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756036Ab2EPTxg (ORCPT ); Wed, 16 May 2012 15:53:36 -0400 Date: Wed, 16 May 2012 12:53:32 -0700 From: Tejun Heo To: Linus Torvalds Cc: Jiri Kosina , Stephen Hemminger , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq Message-ID: <20120516195332.GC21275@google.com> References: <20120516170124.GA21275@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2012 at 12:47:27PM -0700, Linus Torvalds wrote: > On Wed, May 16, 2012 at 12:37 PM, Jiri Kosina wrote: > > +       cancel_delayed_work_sync(&fd_timeout); > > +       cancel_delayed_work_sync(&fd_timer); > > +       destroy_workqueue(system_nrt_wq); > > Well, *that* doesn't look right. > > I think just a "flush_workqueue()" is in order. System wqs shouldn't be flushed (nothing guarantees that flush will finish in fixed amount of time). We probably should make that explicit by whining when someone tries to flush one of the system wqs. Here, the two cancel_delayed_work_sync() calls should be enough. Thanks. -- tejun