[PATCH] staging: gdm72xx: WIMAX_GDM72XX_USB_PM should depend on USB_SUSPEND

[PATCH] staging: gdm72xx: WIMAX_GDM72XX_USB_PM should depend on USB_SUSPEND

[Geert Uytterhoeven]

Use Kconfig logic instead of a rude #error in the driver source,
which breaks m68k-allmodconfig.
Also remove the "default n", as that's the default.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/6335693/

 drivers/staging/gdm72xx/Kconfig   |    2 +-
 drivers/staging/gdm72xx/gdm_usb.c |    6 ------
 2 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index 5c37cba..fc58427 100644
--- a/drivers/staging/gdm72xx/Kconfig
+++ b/drivers/staging/gdm72xx/Kconfig
@@ -38,7 +38,7 @@ if WIMAX_GDM72XX_USB
 
 config WIMAX_GDM72XX_USB_PM
 	bool "Enable power managerment support"
-	default n
+	depends on USB_SUSPEND
 
 endif # WIMAX_GDM72XX_USB
 
diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c
index 004786b..f60e890 100644
--- a/drivers/staging/gdm72xx/gdm_usb.c
+++ b/drivers/staging/gdm72xx/gdm_usb.c
@@ -17,12 +17,6 @@
 #include <linux/usb.h>
 #include <asm/byteorder.h>
 
-#ifdef CONFIG_WIMAX_GDM72XX_USB_PM
-#ifndef CONFIG_USB_SUSPEND
-#error "USB host doesn't support USB Selective Suspend."
-#endif
-#endif
-
 #include "gdm_usb.h"
 #include "gdm_wimax.h"
 #include "usb_boot.h"
-- 
1.7.0.4

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX_USB_PM should depend on USB_SUSPEND

[Greg Kroah-Hartman]

On Wed, May 16, 2012 at 09:47:40PM +0200, Geert Uytterhoeven wrote:
> Use Kconfig logic instead of a rude #error in the driver source,
> which breaks m68k-allmodconfig.
> Also remove the "default n", as that's the default.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> http://kisskb.ellerman.id.au/kisskb/buildresult/6335693/

Sorry about missing that, now applied thanks.

greg k-h