From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, fmhess@users.sourceforge.net,
abbotti@mev.co.uk
Subject: Re: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format
Date: Wed, 16 May 2012 19:18:05 -0700 [thread overview]
Message-ID: <20120517021805.GA32592@kroah.com> (raw)
In-Reply-To: <201205161751.56913.hartleys@visionengravers.com>
On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
> Convert the struct addi_board initialization to C99 format and remove
> all the NULL or 0 initializers. This makes maintaining and editing the
> code simpler and less error prone.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Mori Hess <fmhess@users.sourceforge.net>
>
> ---
>
> This patch is a bit large but should be easy enough to review.
> It does incease the size of the source file in bytes but it reduces
> the lines of code by 1103 lines.
>
> There are 6 checkpatch warnings about lines over 80 characters
> due to the long CamelCase names for some of the functions.
> "Fixing" these actually hurts the readability of the code. The
> checkpatch warnings will be addressed later by renaming the
> CamelCase functions.
Nice job, this driver is a pain to read...
greg k-h
next prev parent reply other threads:[~2012-05-17 2:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 0:51 [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format H Hartley Sweeten
2012-05-17 2:18 ` Greg KH [this message]
2012-05-17 6:15 ` H Hartley Sweeten
2012-05-17 6:45 ` Ian Abbott
2012-05-17 13:32 ` Greg KH
2012-05-17 15:57 ` Ian Abbott
2012-05-17 16:38 ` H Hartley Sweeten
2012-05-17 18:28 ` Ian Abbott
2012-05-17 21:12 ` H Hartley Sweeten
2012-05-18 10:05 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517021805.GA32592@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox