From: Wim Van Sebroeck <wim@iguana.be>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH -next] wdt: fix iTCO printk format warnings
Date: Thu, 17 May 2012 09:14:49 +0200 [thread overview]
Message-ID: <20120517071449.GT3074@spo001.leaseweb.com> (raw)
In-Reply-To: <4FB167D8.9000905@xenotime.net>
Hi Randi,
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warnings:
>
> drivers/watchdog/iTCO_wdt.c:577:3: warning: format '%04llx' expects type 'long long unsigned int', but argument 2 has type 'resource_size_t'
> drivers/watchdog/iTCO_wdt.c:594:3: warning: format '%04llx' expects type 'long long unsigned int', but argument 2 has type 'resource_size_t'
> drivers/watchdog/iTCO_wdt.c:600:2: warning: format '%04llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Wim Van Sebroeck <wim@iguana.be>
Had an issue with the patch (I have linenumbers in 800 instead of late 500's).
Any idea why we have this difference?
Below the patch I applied in linux-watchdog-next.
Thanks,
Wim.
---
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
index 9fecb95..2aab56f 100644
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@ -839,7 +839,7 @@ static int __devinit iTCO_wdt_init(struct pci_dev *pdev,
/* The TCO logic uses the TCO_EN bit in the SMI_EN register */
if (!request_region(SMI_EN, 4, "iTCO_wdt")) {
pr_err("I/O address 0x%04lx already in use, device disabled\n",
- SMI_EN);
+ (u64)SMI_EN);
ret = -EIO;
goto out_unmap;
}
@@ -854,7 +854,7 @@ static int __devinit iTCO_wdt_init(struct pci_dev *pdev,
by the TCOBASE value */
if (!request_region(TCOBASE, 0x20, "iTCO_wdt")) {
pr_err("I/O address 0x%04lx already in use, device disabled\n",
- TCOBASE);
+ (u64)TCOBASE);
ret = -EIO;
goto unreg_smi_en;
}
@@ -862,7 +862,7 @@ static int __devinit iTCO_wdt_init(struct pci_dev *pdev,
pr_info("Found a %s TCO device (Version=%d, TCOBASE=0x%04lx)\n",
iTCO_chipset_info[ent->driver_data].name,
iTCO_chipset_info[ent->driver_data].iTCO_version,
- TCOBASE);
+ (u64)TCOBASE);
/* Clear out the (probably old) status */
outw(0x0008, TCO1_STS); /* Clear the Time Out Status bit */
prev parent reply other threads:[~2012-05-17 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 10:03 linux-next: Tree for May 14 Stephen Rothwell
2012-05-14 20:13 ` [PATCH -next] nfc: shdlc needs to select CRC_CCITT Randy Dunlap
2012-05-14 20:32 ` Samuel Ortiz
2012-05-14 20:14 ` [PATCH -next] wdt: ie6xx_wdt needs io.h Randy Dunlap
2012-05-17 7:11 ` Wim Van Sebroeck
2012-05-14 20:15 ` [PATCH -next] wdt: fix iTCO printk format warnings Randy Dunlap
2012-05-17 7:14 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517071449.GT3074@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox