From: Grant Likely <grant.likely@secretlab.ca>
To: Peter Korsgaard <jacmet@sunsite.dk>, linux-kernel@vger.kernel.org
Cc: Peter Korsgaard <jacmet@sunsite.dk>
Subject: Re: [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display
Date: Thu, 17 May 2012 18:01:33 -0600 [thread overview]
Message-ID: <20120518000133.C2EA43E062C@localhost> (raw)
In-Reply-To: <1335347513-5831-1-git-send-email-jacmet@sunsite.dk>
On Wed, 25 Apr 2012 11:51:53 +0200, Peter Korsgaard <jacmet@sunsite.dk> wrote:
> Pullups are enabled when bits are set, not when cleared.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-mcp23s08.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
> index c5d83a8..0f42518 100644
> --- a/drivers/gpio/gpio-mcp23s08.c
> +++ b/drivers/gpio/gpio-mcp23s08.c
> @@ -353,7 +353,7 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> chip->base + t, bank, t, label,
> (mcp->cache[MCP_IODIR] & mask) ? "in " : "out",
> (mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
> - (mcp->cache[MCP_GPPU] & mask) ? " " : "up");
> + (mcp->cache[MCP_GPPU] & mask) ? "up" : " ");
> /* NOTE: ignoring the irq-related registers */
> seq_printf(s, "\n");
> }
> --
> 1.7.10
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
prev parent reply other threads:[~2012-05-18 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 9:51 [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display Peter Korsgaard
2012-05-18 0:01 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518000133.C2EA43E062C@localhost \
--to=grant.likely@secretlab.ca \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox