* [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display
@ 2012-04-25 9:51 Peter Korsgaard
2012-05-18 0:01 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2012-04-25 9:51 UTC (permalink / raw)
To: grant.likely, linux-kernel; +Cc: Peter Korsgaard
Pullups are enabled when bits are set, not when cleared.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
drivers/gpio/gpio-mcp23s08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index c5d83a8..0f42518 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -353,7 +353,7 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
chip->base + t, bank, t, label,
(mcp->cache[MCP_IODIR] & mask) ? "in " : "out",
(mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
- (mcp->cache[MCP_GPPU] & mask) ? " " : "up");
+ (mcp->cache[MCP_GPPU] & mask) ? "up" : " ");
/* NOTE: ignoring the irq-related registers */
seq_printf(s, "\n");
}
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display
2012-04-25 9:51 [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display Peter Korsgaard
@ 2012-05-18 0:01 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-05-18 0:01 UTC (permalink / raw)
To: Peter Korsgaard, linux-kernel; +Cc: Peter Korsgaard
On Wed, 25 Apr 2012 11:51:53 +0200, Peter Korsgaard <jacmet@sunsite.dk> wrote:
> Pullups are enabled when bits are set, not when cleared.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-mcp23s08.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
> index c5d83a8..0f42518 100644
> --- a/drivers/gpio/gpio-mcp23s08.c
> +++ b/drivers/gpio/gpio-mcp23s08.c
> @@ -353,7 +353,7 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> chip->base + t, bank, t, label,
> (mcp->cache[MCP_IODIR] & mask) ? "in " : "out",
> (mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
> - (mcp->cache[MCP_GPPU] & mask) ? " " : "up");
> + (mcp->cache[MCP_GPPU] & mask) ? "up" : " ");
> /* NOTE: ignoring the irq-related registers */
> seq_printf(s, "\n");
> }
> --
> 1.7.10
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-18 0:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-25 9:51 [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display Peter Korsgaard
2012-05-18 0:01 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox