From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com,
fweisbec@gmail.com, patches@linaro.org
Subject: Re: [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU's source code.
Date: Fri, 18 May 2012 08:33:08 +0200 [thread overview]
Message-ID: <20120518063308.GA429@gmail.com> (raw)
In-Reply-To: <1337293209.4281.111.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, 2012-05-17 at 15:12 -0700, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> >
> > Although the C language allows you to break strings across lines, doing
> > this makes it hard for people to find the Linux kernel code corresponding
> > to a given console message. This commit therefore fixes broken strings
> > throughout RCU's source code.
>
> While I'm not a strict 80 chars zealot, I do find exceedingly
> long lines utterly annoying, editors either wrap them in the
> most hideous way or you don't see them.
Well, but if it's exceedingly long in the editor then it's
probably exceedingly long in the syslog as well and need fixing,
right?
Or it's printed inside some exceedingly deep nested block of
code, which too could use improvement, right?
Thanks,
Ingo
next prev parent reply other threads:[~2012-05-18 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 22:12 [PATCH tip/core/rcu 0/2] Code-style fixes Paul E. McKenney
2012-05-17 22:12 ` [PATCH RFC tip/core/rcu 1/2] rcu: Fix code-style issues involving "else" Paul E. McKenney
2012-05-17 22:12 ` [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU's source code Paul E. McKenney
2012-05-17 22:20 ` Peter Zijlstra
2012-05-17 22:32 ` Josh Triplett
2012-05-17 22:32 ` Paul Bolle
2012-05-18 6:33 ` Ingo Molnar [this message]
2012-05-18 12:33 ` Paul E. McKenney
2012-05-17 22:23 ` Josh Triplett
2012-05-17 22:41 ` Paul E. McKenney
2012-05-17 22:27 ` Peter Zijlstra
2012-05-17 22:43 ` Paul E. McKenney
2012-05-17 22:24 ` [PATCH RFC tip/core/rcu 1/2] rcu: Fix code-style issues involving "else" Josh Triplett
2012-05-18 7:38 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518063308.GA429@gmail.com \
--to=mingo@kernel.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=patches@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox