From: Dan Carpenter <dan.carpenter@oracle.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
Aaron Lu <Aaron.Lu@amd.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>
Subject: [patch] [SCSI] scsi_pm: passing wrong pointer to resume()
Date: Fri, 18 May 2012 17:08:27 +0300 [thread overview]
Message-ID: <20120518140827.GA1584@elgon.mountain> (raw)
This gets caught by GCC:
drivers/scsi/scsi_pm.c:30:5: warning: passing argument 1 of
‘scsi_device_resume’ from incompatible pointer type
[enabled by default]
It probably would have been caught in testing as well, but it's on an
error path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I haven't tested this. :/ Sorry for that.
diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
index 9bd2c41..d4201de 100644
--- a/drivers/scsi/scsi_pm.c
+++ b/drivers/scsi/scsi_pm.c
@@ -27,7 +27,7 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg)
if (drv && drv->suspend) {
err = drv->suspend(dev, msg);
if (err)
- scsi_device_resume(dev);
+ scsi_device_resume(to_scsi_device(dev));
}
}
dev_dbg(dev, "scsi suspend: %d\n", err);
next reply other threads:[~2012-05-18 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 14:08 Dan Carpenter [this message]
[not found] ` <2FB252790F768E479D722B6F9B6D68C4B03E50@SCYBEXDAG02.amd.com>
2012-05-19 3:38 ` [patch] [SCSI] scsi_pm: passing wrong pointer to resume() Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518140827.GA1584@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=Aaron.Lu@amd.com \
--cc=JBottomley@parallels.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox