From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Staging: ipack: improve the register of a bus and a device in the bus.
Date: Fri, 18 May 2012 17:35:51 -0700 [thread overview]
Message-ID: <20120519003551.GB2206@kroah.com> (raw)
In-Reply-To: <1337332208-26057-1-git-send-email-siglesias@igalia.com>
On Fri, May 18, 2012 at 11:10:05AM +0200, Samuel Iglesias Gonsalvez wrote:
> It adds and removes some fields in the struct ipack_device and
> ipack_bus_device to make it cleaner.
>
> The API has change to group all the operations on these structures inside
> of the ipack driver.
>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
> ---
> drivers/staging/ipack/bridges/tpci200.c | 63 +++++++--------------------
> drivers/staging/ipack/bridges/tpci200.h | 2 +-
> drivers/staging/ipack/devices/ipoctal.c | 55 ++++++++++++++----------
> drivers/staging/ipack/ipack.c | 57 +++++++++++++++++++------
> drivers/staging/ipack/ipack.h | 71 +++++++++++++++++--------------
> 5 files changed, 131 insertions(+), 117 deletions(-)
Much better, thanks for reworking this. Hopefully it makes more sense
now.
greg k-h
prev parent reply other threads:[~2012-05-19 0:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 9:10 [PATCH 1/4] Staging: ipack: improve the register of a bus and a device in the bus Samuel Iglesias Gonsalvez
2012-05-18 9:10 ` [PATCH 2/4] Staging: ipack: remove board_name and bus_name fields from struct ipack_device Samuel Iglesias Gonsalvez
2012-05-19 0:35 ` Greg Kroah-Hartman
2012-05-18 9:10 ` [PATCH 3/4] Staging ipack/bridges/tpci200: remove TPCI200_SHORTNAME constant Samuel Iglesias Gonsalvez
2012-05-19 0:37 ` [PATCH 3/4] Staging: " Greg Kroah-Hartman
2012-05-23 10:13 ` Samuel Iglesias Gonsálvez
2012-05-23 14:04 ` Greg Kroah-Hartman
2012-05-18 9:10 ` [PATCH 4/4] Staging: ipack/bridges/tpci200: remove unneeded casts Samuel Iglesias Gonsalvez
2012-05-19 0:35 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519003551.GB2206@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox