From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: use correct device for device supply lookup
Date: Sat, 19 May 2012 18:40:53 +0100 [thread overview]
Message-ID: <20120519174052.GX4039@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FB7D676.9000609@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
On Sat, May 19, 2012 at 10:50:54PM +0530, Laxman Dewangan wrote:
> > static struct regulator_dev *regulator_dev_lookup(struct device *dev,
> > const char *supply,
> > int *ret)
> >
> Also in regulator_register we set the of_node as
> rdev->dev.of_node = config->of_node;
So, here we're just setting it to whatever the driver told us to use
which seems about right.
> rdev->dev.parent = dev;
And here we're parenting the class device with the real device we were
passed which again seems obvious.
> Passed config->of_node will only be used if we pass the rdev->dev,
> not rdev->dev.parent
What does this mean and how is it related to anything you've said above?
I'm sorry but I really can't make head nor tail of what you're trying to
say here, there's just lots and lots of statements here but I'm
struggling to understand how they are related to each other.
> Am I missing anything here in understanding?
I certainly am. Please go back to square one: what's the problem you
are seeing here? Then go forward and step by step relate it to the code
change.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-19 17:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 14:14 [PATCH] regulator: core: use correct device for device supply lookup Laxman Dewangan
2012-05-19 16:41 ` Mark Brown
2012-05-19 17:14 ` Laxman Dewangan
2012-05-19 17:20 ` Laxman Dewangan
2012-05-19 17:40 ` Mark Brown [this message]
2012-05-19 17:56 ` Laxman Dewangan
2012-05-19 18:26 ` Mark Brown
2012-05-19 19:03 ` Laxman Dewangan
2012-05-19 20:50 ` Mark Brown
2012-05-19 21:13 ` Laxman Dewangan
2012-05-19 23:13 ` Mark Brown
2012-05-20 7:34 ` Laxman Dewangan
2012-05-20 9:01 ` Mark Brown
[not found] ` <4FB8C9EF.7010400@nvidia.com>
2012-05-20 12:06 ` Mark Brown
2012-05-20 12:14 ` Laxman Dewangan
2012-05-20 12:10 ` Laxman Dewangan
2012-05-19 17:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519174052.GX4039@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox