From: Samuel Ortiz <sameo@linux.intel.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: broonie@opensource.wolfsonmicro.com, lrg@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: tps65910: fixed build error
Date: Sun, 20 May 2012 17:28:17 +0200 [thread overview]
Message-ID: <20120520152817.GY12015@sortiz-mobl> (raw)
In-Reply-To: <1337342245-23154-1-git-send-email-ldewangan@nvidia.com>
Hi Laxman,
On Fri, May 18, 2012 at 05:27:25PM +0530, Laxman Dewangan wrote:
> Some of the api calls are not changed and it leads
> to following build error:
> /regulator/tps65910-regulator.c: In function 'tps65910_enable':
> /regulator/tps65910-regulator.c:491:2: error: implicit declaration of
> function 'tps65910_set_bits'
> /regulator/tps65910-regulator.c: In function 'tps65910_disable':
> /regulator/tps65910-regulator.c:504:2: error: implicit declaration of
> function 'tps65910_clear_bits'
> /regulator/tps65910-regulator.c: In function 'tps65910_get_voltage':
> /regulator/tps65910-regulator.c:628:2: warning: passing argument 1 of
> 'tps65910_reg_read' from incompatible pointer type]
> /linux/mfd/tps65910.h:856:19: note: expected 'struct tps65910 *' but
> argument is of type 'struct tps65910_reg *'
> /regulator/tps65910-regulator.c:628:2: error: too few arguments to
> function 'tps65910_reg_read'
>
> cc1: some warnings being treated as errors
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> This patch fixes the compilation error in Samuel's tree and should go
> through Samuel's for-next.
Thanks, I squashed this one into the initial patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-05-20 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 11:57 [PATCH] regulator: tps65910: fixed build error Laxman Dewangan
2012-05-18 16:37 ` Mark Brown
2012-05-20 15:28 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520152817.GY12015@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox