From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: akpm@linux-foundation.org, manfred@colorfullife.com,
a.p.zijlstra@chello.nl, josh@joshtriplett.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]ipc:fixed spacing issues in coding style.
Date: Sun, 20 May 2012 08:44:58 -0700 [thread overview]
Message-ID: <20120520154458.GG2895@linux.vnet.ibm.com> (raw)
In-Reply-To: <1337511673-3485-1-git-send-email-ahiliation@yahoo.co.in>
On Sun, May 20, 2012 at 04:31:13PM +0530, Jeffrin Jose wrote:
> Fixed spacing issues related to different operators
> like * and : found by checkpatch.pl tool in ipc/sem.c
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
Looks good to me!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> ipc/sem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 10386b8..9301595 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -964,7 +964,7 @@ static int semctl_nolock(struct ipc_namespace *ns, int semid,
> up_read(&sem_ids(ns).rw_mutex);
> if (copy_to_user (arg.__buf, &seminfo, sizeof(struct seminfo)))
> return -EFAULT;
> - return (max_id < 0) ? 0: max_id;
> + return (max_id < 0) ? 0 : max_id;
> }
> case IPC_STAT:
> case SEM_STAT:
> @@ -1372,7 +1372,7 @@ static struct sem_undo *find_alloc_undo(struct ipc_namespace *ns, int semid)
> spin_lock(&ulp->lock);
> un = lookup_undo(ulp, semid);
> spin_unlock(&ulp->lock);
> - if (likely(un!=NULL))
> + if (likely(un != NULL))
> goto out;
> rcu_read_unlock();
>
> @@ -1732,7 +1732,7 @@ void exit_sem(struct task_struct *tsk)
>
> /* perform adjustments registered in un */
> for (i = 0; i < sma->sem_nsems; i++) {
> - struct sem * semaphore = &sma->sem_base[i];
> + struct sem *semaphore = &sma->sem_base[i];
> if (un->semadj[i]) {
> semaphore->semval += un->semadj[i];
> /*
> --
> 1.7.10
>
next prev parent reply other threads:[~2012-05-20 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 11:01 [PATCH]ipc:fixed spacing issues in coding style Jeffrin Jose
2012-05-20 15:44 ` Paul E. McKenney [this message]
2012-05-20 19:04 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520154458.GG2895@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ahiliation@yahoo.co.in \
--cc=akpm@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox