* [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file
@ 2012-05-18 22:46 Paul Gortmaker
2012-05-19 1:08 ` Chris Metcalf
0 siblings, 1 reply; 6+ messages in thread
From: Paul Gortmaker @ 2012-05-18 22:46 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Gortmaker, Chris Metcalf
To fix this:
~/git/linux-head$ make defconfig
*** Default configuration is based on 'tile_defconfig'
***
*** Can't find default configuration "arch/tile/configs/tile_defconfig"!
***
make[1]: *** [defconfig] Error 1
make: *** [defconfig] Error 2
There is no need to use $ARCH in the tile/Makefile, since if we are
in there, we know ARCH must be tile. Use the GX as the defconfig,
as that is what is used in linux-next.
Cc: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/arch/tile/Makefile b/arch/tile/Makefile
index 5015144..89f2310 100644
--- a/arch/tile/Makefile
+++ b/arch/tile/Makefile
@@ -34,7 +34,7 @@ LIBGCC_PATH := \
$(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
# Provide the path to use for "make defconfig".
-KBUILD_DEFCONFIG := $(ARCH)_defconfig
+KBUILD_DEFCONFIG := tilegx_defconfig
# Used as a file extension when useful, e.g. head_$(BITS).o
# Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file
2012-05-18 22:46 [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file Paul Gortmaker
@ 2012-05-19 1:08 ` Chris Metcalf
2012-05-19 3:18 ` Paul Gortmaker
0 siblings, 1 reply; 6+ messages in thread
From: Chris Metcalf @ 2012-05-19 1:08 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel
On 5/18/2012 6:46 PM, Paul Gortmaker wrote:
> To fix this:
>
> ~/git/linux-head$ make defconfig
> *** Default configuration is based on 'tile_defconfig'
> ***
> *** Can't find default configuration "arch/tile/configs/tile_defconfig"!
> ***
> make[1]: *** [defconfig] Error 1
> make: *** [defconfig] Error 2
>
> There is no need to use $ARCH in the tile/Makefile, since if we are
> in there, we know ARCH must be tile. Use the GX as the defconfig,
> as that is what is used in linux-next.
No, the odd thing about arch/tile is that you must build it either as
ARCH=tilepro or ARCH=tilegx. There is no ARCH=tile. So the $ARCH piece is
actually correct.
> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> diff --git a/arch/tile/Makefile b/arch/tile/Makefile
> index 5015144..89f2310 100644
> --- a/arch/tile/Makefile
> +++ b/arch/tile/Makefile
> @@ -34,7 +34,7 @@ LIBGCC_PATH := \
> $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
>
> # Provide the path to use for "make defconfig".
> -KBUILD_DEFCONFIG := $(ARCH)_defconfig
> +KBUILD_DEFCONFIG := tilegx_defconfig
>
> # Used as a file extension when useful, e.g. head_$(BITS).o
> # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file
2012-05-19 1:08 ` Chris Metcalf
@ 2012-05-19 3:18 ` Paul Gortmaker
2012-05-19 14:04 ` Chris Metcalf
2012-05-20 19:15 ` [PATCH] tile: default to tilegx_defconfig for ARCH=tile Chris Metcalf
0 siblings, 2 replies; 6+ messages in thread
From: Paul Gortmaker @ 2012-05-19 3:18 UTC (permalink / raw)
To: Chris Metcalf; +Cc: linux-kernel
[Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file] On 18/05/2012 (Fri 21:08) Chris Metcalf wrote:
> On 5/18/2012 6:46 PM, Paul Gortmaker wrote:
> > To fix this:
> >
> > ~/git/linux-head$ make defconfig
> > *** Default configuration is based on 'tile_defconfig'
> > ***
> > *** Can't find default configuration "arch/tile/configs/tile_defconfig"!
> > ***
> > make[1]: *** [defconfig] Error 1
> > make: *** [defconfig] Error 2
> >
> > There is no need to use $ARCH in the tile/Makefile, since if we are
> > in there, we know ARCH must be tile. Use the GX as the defconfig,
> > as that is what is used in linux-next.
>
> No, the odd thing about arch/tile is that you must build it either as
> ARCH=tilepro or ARCH=tilegx. There is no ARCH=tile. So the $ARCH piece is
> actually correct.
That is interesting, since this is what I've been doing on any of my
tile builds right from the beginning.
PATH=/home/paul/tc/tilegx-x86_64/bin:$PATH
export CROSS_COMPILE=tilegx-unknown-linux-gnu-
export ARCH=tile
...and it works. Aside from the defconfig thing I just reported.
It is the same boilerplate type of env. settings I use for arm, mips
and whatever other random thing I'm building. I'm pretty sure I'm
not the only one who would make this assumption. Actually I *know*
I am not the only one. Here is a snippet from linux-next build:
/scratch/kisskb/prod/kisskb/kisskb3/backend/makewrap.py ARCH=tile
O=/scratch/kisskb/prod/kisskb/kisskb3/backend/build/linux-next_tilegx_defconfig_tilegx
CROSS_COMPILE=/opt/cross/gcc-4.6.2-nolibc/tilegx-linux/bin/tilegx-linux-
tilegx_defconfig
So maybe some validation on the ARCH value is in order if you really
don't want people doing this?
Paul.
--
>
> > Cc: Chris Metcalf <cmetcalf@tilera.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > diff --git a/arch/tile/Makefile b/arch/tile/Makefile
> > index 5015144..89f2310 100644
> > --- a/arch/tile/Makefile
> > +++ b/arch/tile/Makefile
> > @@ -34,7 +34,7 @@ LIBGCC_PATH := \
> > $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
> >
> > # Provide the path to use for "make defconfig".
> > -KBUILD_DEFCONFIG := $(ARCH)_defconfig
> > +KBUILD_DEFCONFIG := tilegx_defconfig
> >
> > # Used as a file extension when useful, e.g. head_$(BITS).o
> > # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
>
> --
> Chris Metcalf, Tilera Corp.
> http://www.tilera.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file
2012-05-19 3:18 ` Paul Gortmaker
@ 2012-05-19 14:04 ` Chris Metcalf
2012-05-20 16:20 ` Paul Gortmaker
2012-05-20 19:15 ` [PATCH] tile: default to tilegx_defconfig for ARCH=tile Chris Metcalf
1 sibling, 1 reply; 6+ messages in thread
From: Chris Metcalf @ 2012-05-19 14:04 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel
On 5/18/2012 11:18 PM, Paul Gortmaker wrote:
> [Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file] On 18/05/2012 (Fri 21:08) Chris Metcalf wrote:
>
>> On 5/18/2012 6:46 PM, Paul Gortmaker wrote:
>>> To fix this:
>>>
>>> ~/git/linux-head$ make defconfig
>>> *** Default configuration is based on 'tile_defconfig'
>>> ***
>>> *** Can't find default configuration "arch/tile/configs/tile_defconfig"!
>>> ***
>>> make[1]: *** [defconfig] Error 1
>>> make: *** [defconfig] Error 2
>>>
>>> There is no need to use $ARCH in the tile/Makefile, since if we are
>>> in there, we know ARCH must be tile. Use the GX as the defconfig,
>>> as that is what is used in linux-next.
>> No, the odd thing about arch/tile is that you must build it either as
>> ARCH=tilepro or ARCH=tilegx. There is no ARCH=tile. So the $ARCH piece is
>> actually correct.
> That is interesting, since this is what I've been doing on any of my
> tile builds right from the beginning.
>
> PATH=/home/paul/tc/tilegx-x86_64/bin:$PATH
> export CROSS_COMPILE=tilegx-unknown-linux-gnu-
> export ARCH=tile
>
> ...and it works. Aside from the defconfig thing I just reported.
> It is the same boilerplate type of env. settings I use for arm, mips
> and whatever other random thing I'm building. I'm pretty sure I'm
> not the only one who would make this assumption. Actually I *know*
> I am not the only one. Here is a snippet from linux-next build:
>
> /scratch/kisskb/prod/kisskb/kisskb3/backend/makewrap.py ARCH=tile
> O=/scratch/kisskb/prod/kisskb/kisskb3/backend/build/linux-next_tilegx_defconfig_tilegx
> CROSS_COMPILE=/opt/cross/gcc-4.6.2-nolibc/tilegx-linux/bin/tilegx-linux-
> tilegx_defconfig
>
> So maybe some validation on the ARCH value is in order if you really
> don't want people doing this?
Yes. I think what I will do is "promote" ARCH=tile to ARCH=tilegx in
arch/tile/Makefile as the "default" Tilera architecture. Thanks for the
suggestion - I've been too close to this issue to actually notice it :-)
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file
2012-05-19 14:04 ` Chris Metcalf
@ 2012-05-20 16:20 ` Paul Gortmaker
0 siblings, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2012-05-20 16:20 UTC (permalink / raw)
To: Chris Metcalf; +Cc: linux-kernel
[Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file] On 19/05/2012 (Sat 10:04) Chris Metcalf wrote:
> On 5/18/2012 11:18 PM, Paul Gortmaker wrote:
[...]
> >
> > So maybe some validation on the ARCH value is in order if you really
> > don't want people doing this?
>
> Yes. I think what I will do is "promote" ARCH=tile to ARCH=tilegx in
> arch/tile/Makefile as the "default" Tilera architecture. Thanks for the
> suggestion - I've been too close to this issue to actually notice it :-)
No problem, I figured that was the case -- that setting ARCH=tile never
crossed your mind since you already knew what was expected by your own
Makefile. :)
Paul.
>
> --
> Chris Metcalf, Tilera Corp.
> http://www.tilera.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] tile: default to tilegx_defconfig for ARCH=tile
2012-05-19 3:18 ` Paul Gortmaker
2012-05-19 14:04 ` Chris Metcalf
@ 2012-05-20 19:15 ` Chris Metcalf
1 sibling, 0 replies; 6+ messages in thread
From: Chris Metcalf @ 2012-05-20 19:15 UTC (permalink / raw)
To: Paul Gortmaker, linux-kernel
There is no "ARCH=tile" (just like there is no "ARCH=x86") so we need
to pick a default configuration, either tilepro or tilegx, when users
specify ARCH=tile. We'll use tilegx, since that's our current chip.
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
arch/tile/Makefile | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/tile/Makefile b/arch/tile/Makefile
index 5015144..55640cf 100644
--- a/arch/tile/Makefile
+++ b/arch/tile/Makefile
@@ -34,7 +34,12 @@ LIBGCC_PATH := \
$(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
# Provide the path to use for "make defconfig".
-KBUILD_DEFCONFIG := $(ARCH)_defconfig
+# We default to the newer TILE-Gx architecture if only "tile" is given.
+ifeq ($(ARCH),tile)
+ KBUILD_DEFCONFIG := tilegx_defconfig
+else
+ KBUILD_DEFCONFIG := $(ARCH)_defconfig
+endif
# Used as a file extension when useful, e.g. head_$(BITS).o
# Not needed for (e.g.) "$(CC) -m32" since the compiler automatically
--
1.6.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-20 19:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-18 22:46 [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file Paul Gortmaker
2012-05-19 1:08 ` Chris Metcalf
2012-05-19 3:18 ` Paul Gortmaker
2012-05-19 14:04 ` Chris Metcalf
2012-05-20 16:20 ` Paul Gortmaker
2012-05-20 19:15 ` [PATCH] tile: default to tilegx_defconfig for ARCH=tile Chris Metcalf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox