From: Josh Triplett <josh@joshtriplett.org>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: akpm@linux-foundation.org, manfred@colorfullife.com,
a.p.zijlstra@chello.nl, paulmck@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]ipc:fixed spacing issues in coding style.
Date: Sun, 20 May 2012 12:04:30 -0700 [thread overview]
Message-ID: <20120520190430.GB6475@leaf> (raw)
In-Reply-To: <1337511673-3485-1-git-send-email-ahiliation@yahoo.co.in>
On Sun, May 20, 2012 at 04:31:13PM +0530, Jeffrin Jose wrote:
> Fixed spacing issues related to different operators
> like * and : found by checkpatch.pl tool in ipc/sem.c
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
All three of the spacing fixes in this patch look correct.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
However, I see one instance of another type of spacing issue in the
patch context:
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -964,7 +964,7 @@ static int semctl_nolock(struct ipc_namespace *ns, int semid,
> up_read(&sem_ids(ns).rw_mutex);
> if (copy_to_user (arg.__buf, &seminfo, sizeof(struct seminfo)))
copy_to_user should not have a space before its open parenthesis.
- Josh Triplett
prev parent reply other threads:[~2012-05-20 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 11:01 [PATCH]ipc:fixed spacing issues in coding style Jeffrin Jose
2012-05-20 15:44 ` Paul E. McKenney
2012-05-20 19:04 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520190430.GB6475@leaf \
--to=josh@joshtriplett.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ahiliation@yahoo.co.in \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox