From: Paul Mundt <lethal@linux-sh.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] irqdomain: Simple NUMA awareness.
Date: Mon, 21 May 2012 13:46:18 +0900 [thread overview]
Message-ID: <20120521044618.GC31763@linux-sh.org> (raw)
In-Reply-To: <20120519184135.8CFBD3E03B8@localhost>
On Sat, May 19, 2012 at 12:41:35PM -0600, Grant Likely wrote:
> On Sat, 19 May 2012 15:11:44 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> > +static inline int irq_domain_nid(struct device_node *of_node)
> > +{
> > + return of_node ? of_node_to_nid(of_node) : numa_node_id();
> > +}
> > +
>
> I think this logic should just be rolled into of_node_to_nid()
> directly instead of an irq_domain-specific helper. PowerPC and Sparc
> are the only architectures doing anything special with of_node_to_nid
> at the moment. I don't think anyone has bothered to define an
> arch-independent binding for NUMA associations.
>
> Otherwise this patch looks good to me.
>
Ok, that sounds fine to me. I've done that in the updated patch. We do
need to include linux/topology.h for the numa_node_id() definition, but
that seems to not cause too much trouble. Cross builds for sparc and
powerpc OF + NUMA platforms seem to hold up at least.
next prev parent reply other threads:[~2012-05-21 4:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 6:11 [PATCH 0/8] irqdomain cleanups + identity mapping support Paul Mundt
2012-05-19 6:11 ` [PATCH 1/8] irqdomain: Support removal of IRQ domains Paul Mundt
2012-05-19 18:34 ` Grant Likely
2012-05-19 6:11 ` [PATCH 2/8] irqdomain: Export remaining public API symbols Paul Mundt
2012-05-19 18:34 ` Grant Likely
2012-05-19 6:11 ` [PATCH 3/8] irqdomain: Make irq_domain_simple_map() static Paul Mundt
2012-05-19 18:35 ` Grant Likely
2012-05-19 6:11 ` [PATCH 4/8] irqdomain: Simple NUMA awareness Paul Mundt
2012-05-19 18:41 ` Grant Likely
2012-05-21 4:46 ` Paul Mundt [this message]
2012-05-19 6:11 ` [PATCH 5/8] irqdomain: Kill off duplicate definitions Paul Mundt
2012-05-19 18:42 ` Grant Likely
2012-05-19 6:11 ` [PATCH 6/8] irqdomain: Support identity mapped VIRQ allocation Paul Mundt
2012-05-19 20:21 ` Grant Likely
2012-05-21 4:55 ` Paul Mundt
2012-05-19 6:11 ` [PATCH 7/8] irqdomain: trivial pr_fmt conversion Paul Mundt
2012-05-19 6:34 ` Joe Perches
2012-05-19 6:57 ` Paul Mundt
2012-05-19 18:49 ` Grant Likely
2012-05-19 6:11 ` [PATCH 8/8] irqdomain: Support insertion of existing IRQ allocations Paul Mundt
2012-05-19 18:32 ` [PATCH 0/8] irqdomain cleanups + identity mapping support Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521044618.GC31763@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox