From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jonghwa3.lee@samsung.com
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Samuel Oritz <sameo@linux.intel.com>, Liam Girdwood <trg@ti.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Chiwoong Byun <woong.byun@samsung.com>
Subject: Re: [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver
Date: Mon, 21 May 2012 10:55:41 +0100 [thread overview]
Message-ID: <20120521095540.GA1999@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FB9EFBB.20306@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Mon, May 21, 2012 at 04:33:15PM +0900, jonghwa3.lee@samsung.com wrote:
> On 2012년 05월 21일 00:56, Mark Brown wrote:
> > On Fri, May 18, 2012 at 06:32:18PM +0900, Jonghwa Lee wrote:
> >> + }, {
> >> + .name = "EN32KHz PMIC",
> >> + .id = MAX77686_P32KH,
> >> + .ops = &max77686_fixedvolt_ops,
> >> + .type = REGULATOR_VOLTAGE,
> >> + .owner = THIS_MODULE,
> >> + },
> > These should be managed via the clock API now we have one.
> I already updated all your comments except only this one. Could you
> explain more details?
We now have a generic clock framework in drivers/clk so we should be
using that to provide drivers for clocks rather than putting them into
the regulator API which was always a bodge.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-21 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 9:32 [PATCH v3 0/3] Add initial support for MAXIM 77686 mfd chip Jonghwa Lee
2012-05-18 9:32 ` [PATCH 1/3] mfd: MAX77686: Add Maxim 77686 mfd driver Jonghwa Lee
2012-05-20 15:50 ` Mark Brown
2012-05-18 9:32 ` [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver Jonghwa Lee
2012-05-20 15:56 ` Mark Brown
2012-05-21 7:33 ` jonghwa3.lee
2012-05-21 9:55 ` Mark Brown [this message]
2012-05-23 0:40 ` jonghwa3.lee
2012-05-23 10:03 ` Mark Brown
2012-05-18 9:32 ` [PATCH 3/3] rtc: MAX77686: Add Maxim 77686 rtc driver Jonghwa Lee
-- strict thread matches above, loose matches on Subject: below --
2012-05-11 6:36 [PATCH 0/3] mfd: MAX77686: Add initial support for MAXIMG 77686 mfd chip Jonghwa Lee
2012-05-11 6:36 ` [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver Jonghwa Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521095540.GA1999@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=trg@ti.com \
--cc=woong.byun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox