public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "Shai Fultheim (Shai@ScaleMP.com)" <Shai@ScaleMP.com>
Cc: Vlad Zolotarov <vlad@ScaleMP.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Ido Yariv <ido@wizery.com>
Subject: Re: [PATCH v3 0/2] Move x86_cpu_to_apicid to the __read_mostly section
Date: Mon, 21 May 2012 14:32:46 +0200	[thread overview]
Message-ID: <20120521123246.GB17065@gmail.com> (raw)
In-Reply-To: <9B14D1490DDECA4E974F6B9FC9EBAB317D295F4D11@VMBX108.ihostexchange.net>


* Shai Fultheim (Shai@ScaleMP.com) <Shai@ScaleMP.com> wrote:

> Ingo,
> 
> The reason for this, as you pointed out, is the 'cache line' 
> size (4096 bytes).  We see significant false sharing is we do 
> not move this next to each other.

Which write-often variable caused the many cache flushes/fills? 
cpu_to_apicid is read mostly.

I.e. it might make more sense to identify the frequenty 
*modified* percpu variables, and move them to a separate 
section. I *think* most percpu variables are read mostly, so it 
would be more maintainable in the long run to figure out the 
frequently modified ones, not the frequently not modified ones.

Thanks,

	Ingo

  reply	other threads:[~2012-05-21 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20 15:19 [PATCH v3 0/2] Move x86_cpu_to_apicid to the __read_mostly section Vlad Zolotarov
2012-05-21  9:06 ` Ingo Molnar
2012-05-21 10:14   ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-21 12:32     ` Ingo Molnar [this message]
2012-05-21 13:54       ` Vlad Zolotarov
2012-05-21 14:08         ` Ingo Molnar
2012-05-21 14:56           ` Vlad Zolotarov
2012-05-21 15:21             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120521123246.GB17065@gmail.com \
    --to=mingo@kernel.org \
    --cc=Shai@ScaleMP.com \
    --cc=hpa@zytor.com \
    --cc=ido@wizery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vlad@ScaleMP.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox