* [PATCH NEXT]staging: "rts_pstor" Fix typos.
@ 2012-05-21 14:19 Justin P. Mattock
2012-05-21 14:35 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Justin P. Mattock @ 2012-05-21 14:19 UTC (permalink / raw)
To: gregkh; +Cc: wei_wang, devel, linux-kernel, Justin P. Mattock
From: "Justin P. Mattock" <justinmattock@gmail.com>
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
The below patch fixes some typos found while reading through rts_pstor.
drivers/staging/rts_pstor/ms.c | 2 +-
drivers/staging/rts_pstor/sd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
index 0bf6d95..3b75739 100644
--- a/drivers/staging/rts_pstor/ms.c
+++ b/drivers/staging/rts_pstor/ms.c
@@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip)
if (!CHK_MSPRO(ms_card)) {
/* Build table for the last segment,
- * to check if L2P talbe block exist,erasing it
+ * to check if L2P table block exist,erasing it
*/
retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1);
if (retval != STATUS_SUCCESS) {
diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
index aab6909..b9474a8 100644
--- a/drivers/staging/rts_pstor/sd.c
+++ b/drivers/staging/rts_pstor/sd.c
@@ -1169,7 +1169,7 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, u8 mode,
RTSX_DEBUGP("func_group4_mask = 0x%02x\n", buf[0x07]);
} else {
/* Maximum current consumption, check whether current is acceptable;
- * bit[511:496] = 0x0000 means some error happaned.
+ * bit[511:496] = 0x0000 means some error happened.
*/
u16 cc = ((u16)buf[0] << 8) | buf[1];
RTSX_DEBUGP("Maximum current consumption: %dmA\n", cc);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
2012-05-21 14:19 [PATCH NEXT]staging: "rts_pstor" Fix typos Justin P. Mattock
@ 2012-05-21 14:35 ` Dan Carpenter
2012-05-21 14:54 ` Justin P. Mattock
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2012-05-21 14:35 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: gregkh, devel, linux-kernel
On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
> From: "Justin P. Mattock" <justinmattock@gmail.com>
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
^
Your scripts are adding an extra space here.
>
> ---
>
> The below patch fixes some typos found while reading through rts_pstor.
This could go in the patch description if you wanted.
>
> drivers/staging/rts_pstor/ms.c | 2 +-
> drivers/staging/rts_pstor/sd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
> index 0bf6d95..3b75739 100644
> --- a/drivers/staging/rts_pstor/ms.c
> +++ b/drivers/staging/rts_pstor/ms.c
> @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip)
>
> if (!CHK_MSPRO(ms_card)) {
> /* Build table for the last segment,
> - * to check if L2P talbe block exist,erasing it
> + * to check if L2P table block exist,erasing it
I still have no idea what this comment means but "exist" => "exists"
and it needs a space after the comma.
> */
> retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1);
> if (retval != STATUS_SUCCESS) {
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
2012-05-21 14:35 ` Dan Carpenter
@ 2012-05-21 14:54 ` Justin P. Mattock
2012-05-21 15:26 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Justin P. Mattock @ 2012-05-21 14:54 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel
On 05/21/2012 07:35 AM, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
>> From: "Justin P. Mattock"<justinmattock@gmail.com>
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> ^
> Your scripts are adding an extra space here.i
after git format-patch my signature is in the subject line. pressing
enter a few times moves it down. is there a git command for properly
aligning this?
>
>>
>> ---
>>
>> The below patch fixes some typos found while reading through rts_pstor.
>
> This could go in the patch description if you wanted.
>
>>
>> drivers/staging/rts_pstor/ms.c | 2 +-
>> drivers/staging/rts_pstor/sd.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
>> index 0bf6d95..3b75739 100644
>> --- a/drivers/staging/rts_pstor/ms.c
>> +++ b/drivers/staging/rts_pstor/ms.c
>> @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip)
>>
>> if (!CHK_MSPRO(ms_card)) {
>> /* Build table for the last segment,
>> - * to check if L2P talbe block exist,erasing it
>> + * to check if L2P table block exist,erasing it
>
> I still have no idea what this comment means but "exist" => "exists"
> and it needs a space after the comma.
most of them I have no idea as well.. anyway resending with the fixes..
>
>> */
>> retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1);
>> if (retval != STATUS_SUCCESS) {
>
> regards,
> dan carpenter
>
Justin P. Mattock
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
2012-05-21 14:54 ` Justin P. Mattock
@ 2012-05-21 15:26 ` Dan Carpenter
2012-05-21 15:30 ` Justin P. Mattock
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2012-05-21 15:26 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: gregkh, devel, linux-kernel
On Mon, May 21, 2012 at 07:54:47AM -0700, Justin P. Mattock wrote:
> On 05/21/2012 07:35 AM, Dan Carpenter wrote:
> >On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
> >>From: "Justin P. Mattock"<justinmattock@gmail.com>
> >>
> >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> > ^
> >Your scripts are adding an extra space here.i
>
> after git format-patch my signature is in the subject line. pressing
> enter a few times moves it down. is there a git command for properly
> aligning this?
The first line is the subject and then you need to leave the next
line of the commit blank.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
2012-05-21 15:26 ` Dan Carpenter
@ 2012-05-21 15:30 ` Justin P. Mattock
0 siblings, 0 replies; 5+ messages in thread
From: Justin P. Mattock @ 2012-05-21 15:30 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel
On 05/21/2012 08:26 AM, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 07:54:47AM -0700, Justin P. Mattock wrote:
>> On 05/21/2012 07:35 AM, Dan Carpenter wrote:
>>> On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
>>>> From: "Justin P. Mattock"<justinmattock@gmail.com>
>>>>
>>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>> ^
>>> Your scripts are adding an extra space here.i
>>
>> after git format-patch my signature is in the subject line. pressing
>> enter a few times moves it down. is there a git command for properly
>> aligning this?
>
> The first line is the subject and then you need to leave the next
> line of the commit blank.
>
> regards,
> dan carpenter
>
>
ahh.. I know what im doing wrong, im not doing all of this while doing
git commit -s -a. I add the subject etc.. after committing and
formatting the patch.
Justin P. Mattock
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-21 15:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 14:19 [PATCH NEXT]staging: "rts_pstor" Fix typos Justin P. Mattock
2012-05-21 14:35 ` Dan Carpenter
2012-05-21 14:54 ` Justin P. Mattock
2012-05-21 15:26 ` Dan Carpenter
2012-05-21 15:30 ` Justin P. Mattock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox