From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: optimize ISR lookups
Date: Tue, 22 May 2012 01:24:49 +0300 [thread overview]
Message-ID: <20120521222449.GJ17031@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1205220012020.3231@ionos>
On Tue, May 22, 2012 at 12:14:18AM +0200, Thomas Gleixner wrote:
> On Tue, 22 May 2012, Michael S. Tsirkin wrote:
>
> > On Mon, May 21, 2012 at 11:04:25PM +0200, Thomas Gleixner wrote:
> > > > @@ -242,6 +262,25 @@ static inline void apic_clear_irr(int vec, struct kvm_lapic *apic)
> > > > apic->irr_pending = true;
> > > > }
> > > >
> > > > +static inline void apic_set_isr(int vec, struct kvm_lapic *apic)
> > > > +{
> > > > + if (!__apic_test_and_set_vector(vec, apic->regs + APIC_ISR))
> > > > + ++apic->isr_count;
> > > > + ASSERT(apic->isr_count > MAX_APIC_VECTOR);
> > >
> > > I'm really curious what you observed when defining DEBUG in that file.
> > >
> > > Clearly you never did.
> >
> > Sorry :(
> > Yes clearly silly, thanks for pointing this out.
>
> That's all you have a reply for? That's the least of the problems ....
Others are not my fault :)
Seriously, if Avi/Marcelo want to rewrite the ISR emulation
I can help. If they want to keep it 1:1 with hardware
then what I wrote seems the only way.
So waiting for them to respond.
--
MST
next prev parent reply other threads:[~2012-05-21 22:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 16:37 [PATCH] kvm: optimize ISR lookups Michael S. Tsirkin
2012-05-21 18:44 ` Michael S. Tsirkin
2012-05-21 21:04 ` Thomas Gleixner
2012-05-21 21:51 ` Michael S. Tsirkin
2012-05-21 22:14 ` Thomas Gleixner
2012-05-21 22:24 ` Michael S. Tsirkin [this message]
2012-05-21 22:44 ` Thomas Gleixner
2012-05-21 22:50 ` Michael S. Tsirkin
2012-05-21 23:01 ` Thomas Gleixner
2012-05-22 10:46 ` Avi Kivity
2012-05-23 14:48 ` Ingo Molnar
2012-05-23 15:03 ` Avi Kivity
2012-05-23 20:10 ` Thomas Gleixner
2012-05-23 20:46 ` Michael S. Tsirkin
2012-05-23 23:02 ` Thomas Gleixner
2012-05-23 15:14 ` Michael S. Tsirkin
2012-05-23 19:22 ` H. Peter Anvin
2012-05-21 23:11 ` Thomas Gleixner
2012-05-21 23:06 ` Michael S. Tsirkin
2012-05-21 23:12 ` H. Peter Anvin
2012-05-21 23:36 ` Thomas Gleixner
2012-05-22 10:59 ` Avi Kivity
2012-05-22 17:26 ` Thomas Gleixner
2012-05-23 15:10 ` Avi Kivity
2012-05-23 18:37 ` Thomas Gleixner
2012-05-23 19:25 ` H. Peter Anvin
2012-05-23 22:00 ` Thomas Gleixner
2012-05-30 14:18 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521222449.GJ17031@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).