From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: cl@linux.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
aarcange@redhat.com, kosaki.motohiro@jp.fujitsu.com,
hughd@google.com, rientjes@google.com, adobriyan@gmail.com,
mel@csn.ul.ie
Subject: Re: [PATCH] hugetlb: fix resv_map leak in error path
Date: Tue, 22 May 2012 13:45:58 -0700 [thread overview]
Message-ID: <20120522134558.49255899.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120521202814.E01F0FE1@kernel>
On Mon, 21 May 2012 13:28:14 -0700
Dave Hansen <dave@linux.vnet.ibm.com> wrote:
> When called for anonymous (non-shared) mappings,
> hugetlb_reserve_pages() does a resv_map_alloc(). It depends on
> code in hugetlbfs's vm_ops->close() to release that allocation.
>
> However, in the mmap() failure path, we do a plain unmap_region()
> without the remove_vma() which actually calls vm_ops->close().
>
> This is a decent fix. This leak could get reintroduced if
> new code (say, after hugetlb_reserve_pages() in
> hugetlbfs_file_mmap()) decides to return an error. But, I think
> it would have to unroll the reservation anyway.
How far back does this bug go? The patch applies to 3.4 but gets
rejects in 3.3 and earlier.
> This hasn't been extensively tested. Pretty much compile and
> boot tested along with Christoph's test case:
>
> http://marc.info/?l=linux-mm&m=133728900729735
That isn't my favoritest ever changelog text :(
next prev parent reply other threads:[~2012-05-22 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 20:28 [PATCH] hugetlb: fix resv_map leak in error path Dave Hansen
2012-05-21 22:01 ` KOSAKI Motohiro
2012-05-22 20:45 ` Andrew Morton [this message]
2012-05-22 20:59 ` Dave Hansen
2012-05-22 21:05 ` Christoph Lameter
2012-05-22 21:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522134558.49255899.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=cl@linux.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox