From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-3.6] debugfs: change parameter check in debugfs_remove() functions
Date: Wed, 23 May 2012 06:29:12 -0700 [thread overview]
Message-ID: <20120523132912.GA23310@kroah.com> (raw)
In-Reply-To: <1337778788-7069-1-git-send-email-arend@broadcom.com>
On Wed, May 23, 2012 at 03:13:07PM +0200, Arend van Spriel wrote:
> The dentry parameter in debugfs_remove() and debugfs_remove_recursive()
> is checked being a NULL pointer. To make cleanup by callers easier this
> check is extended using the IS_ERR_OR_NULL macro instead because the
> debugfs_create_... functions can return a ERR_PTR() value.
>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> I was adding the check in driver code before calling the recursive remove,
> but considered it might be a better idea to do it in debugfs itself.
Yes, nice change, thanks.
I'll queue it up after 3.5-rc1 is out.
thanks,
greg k-h
prev parent reply other threads:[~2012-05-23 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 13:13 [PATCH for-3.6] debugfs: change parameter check in debugfs_remove() functions Arend van Spriel
2012-05-23 13:29 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523132912.GA23310@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arend@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox