From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Staging: ipack/bridges/tpci200: remove TPCI200_SHORTNAME constant
Date: Wed, 23 May 2012 07:04:51 -0700 [thread overview]
Message-ID: <20120523140451.GA8088@kroah.com> (raw)
In-Reply-To: <1337768001.3666.6.camel@fourier.local.igalia.com>
On Wed, May 23, 2012 at 12:13:21PM +0200, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-05-18 at 17:37 -0700, Greg Kroah-Hartman wrote:
> [...]
> > > if (dev->slot >= TPCI200_NB_SLOT) {
> > > - pr_info("Slot [%s %d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> > > - TPCI200_SHORTNAME, dev->bus_nr, dev->slot,
> > > - TPCI200_NB_SLOT-1);
> > > + pr_info("Slot [%d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> > > + dev->bus_nr, dev->slot, TPCI200_NB_SLOT-1);
> >
> > All of these should really be dev_err() calls, right?
> >
> > You should have no pr_* calls at all in any driver, and probably none in
> > the ipack core as well, care to fix them all up?
>
> Yes, I will fix it in the next bunch of patches. I don't forget it.
>
> By the way, sometime ago, you suggested me to use the ics interface for
> giving the bus number if there is no HW boundary of the number of them.
> However, I searched the source code and I didn't find any reference to
> the ics interface. Can you tell me where is it declared?
My appologies, I should have said "idr" interface, there is a reason why
you couldn't find any "ics" code :)
Sorry about that,
greg k-h
next prev parent reply other threads:[~2012-05-23 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 9:10 [PATCH 1/4] Staging: ipack: improve the register of a bus and a device in the bus Samuel Iglesias Gonsalvez
2012-05-18 9:10 ` [PATCH 2/4] Staging: ipack: remove board_name and bus_name fields from struct ipack_device Samuel Iglesias Gonsalvez
2012-05-19 0:35 ` Greg Kroah-Hartman
2012-05-18 9:10 ` [PATCH 3/4] Staging ipack/bridges/tpci200: remove TPCI200_SHORTNAME constant Samuel Iglesias Gonsalvez
2012-05-19 0:37 ` [PATCH 3/4] Staging: " Greg Kroah-Hartman
2012-05-23 10:13 ` Samuel Iglesias Gonsálvez
2012-05-23 14:04 ` Greg Kroah-Hartman [this message]
2012-05-18 9:10 ` [PATCH 4/4] Staging: ipack/bridges/tpci200: remove unneeded casts Samuel Iglesias Gonsalvez
2012-05-19 0:35 ` [PATCH 1/4] Staging: ipack: improve the register of a bus and a device in the bus Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523140451.GA8088@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox