From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: linux-kernel@vger.kernel.org, Russ.Dill@ti.com, mporter@ti.com
Subject: Re: [PATCH] [ARM] Unconditional call to smp_cross_call on UP crashes
Date: Wed, 23 May 2012 19:52:48 +0100 [thread overview]
Message-ID: <20120523185248.GA6908@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1337879399-9998-1-git-send-email-panto@antoniou-consulting.com>
On Thu, May 24, 2012 at 05:09:59PM +0000, Pantelis Antoniou wrote:
> omap2plus_defconfig builds with SMP & SMP_ON_UP set.
> On beagle (which is UP) is_smp() returns false and we don't call
> smp_init_cpus which in turn does not initialize smp_cross_call which
> remains NULL.
>
> When issuing a reboot we OOPS with a NULL dereference on stop smp_call.
>
> Fixed by checking is_smp in smp_send_stop()
1. No sign-off, so this patch _can't_ be committed.
2. Poor description. You say it oopses, but you don't include the oops.
So, when I read this I've no idea exactly why this is failing. And it
_shouldn't_ fail, so I want to know what you are seeing.
next prev parent reply other threads:[~2012-05-23 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 17:09 [PATCH] [ARM] Unconditional call to smp_cross_call on UP crashes Pantelis Antoniou
2012-05-23 17:45 ` Russ Dill
2012-05-23 18:52 ` Russell King - ARM Linux [this message]
2012-05-23 19:17 ` Russell King - ARM Linux
2012-05-23 18:55 ` Porter, Matt
-- strict thread matches above, loose matches on Subject: below --
2012-05-24 19:38 Pantelis Antoniou
2012-05-24 19:50 Pantelis Antoniou
2012-05-24 16:17 ` Russell King - ARM Linux
2012-05-24 16:55 ` Pantelis Antoniou
2012-05-24 17:15 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523185248.GA6908@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Russ.Dill@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox