From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 1/2] regmap: allow busses to request formatting with specific endianness
Date: Thu, 24 May 2012 00:35:43 +0100 [thread overview]
Message-ID: <20120523233542.GC5361@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FBD72A7.907@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Wed, May 23, 2012 at 05:28:39PM -0600, Stephen Warren wrote:
> I did briefly consider making this a property of regmap_config rather
> than regmap_bus, but as you say, it'd mean every MMIO user would have
> to specify the endianness value.
I didn't say that, that'd be appauling!
> Also, it doesn't seem right for a device to be able to specify
> register formatting endianness for MMIO; presumably we'd always want
> that native.
Depends on what's going on with bought in IP and register map standards
(and things like PCI) - you do get non-native IPs turning up often enough.
> I suppose we could avoid every device having to specify the endianness
> by introducing a fourth "DEFAULT" value == 0, and having the bus
> define what default means - that way, I wouldn't have to edit any
> drivers due to adding the regmap_bus field.
That's absolutely essential, there's already an explicit idea of this in
the current code's assumption that everything is big endian.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-23 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 22:33 [PATCH 1/2] regmap: allow busses to request formatting with specific endianness Stephen Warren
2012-05-23 22:33 ` [PATCH 2/2] regmap: mmio: request native endian formatting Stephen Warren
2012-05-23 23:16 ` [PATCH 1/2] regmap: allow busses to request formatting with specific endianness Mark Brown
2012-05-23 23:28 ` Stephen Warren
2012-05-23 23:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523233542.GC5361@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox