From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH] swiotlb: add "dma_attrs" argument to alloc and free, to match dma_map_ops
Date: Thu, 24 May 2012 13:47:41 -0400 [thread overview]
Message-ID: <20120524174741.GG24934@phenom.dumpdata.com> (raw)
In-Reply-To: <20120524114422.GA25950@mail.gnudd.com>
On Thu, May 24, 2012 at 01:44:22PM +0200, Alessandro Rubini wrote:
> The alloc and free pointers within "struct dma_map_ops" receive a
> pointer to dma_attrs that was not present in the generic swiotlb
> functions. For this reason, a few files had a local wrapper for the
> free function that just removes the attrs argument before calling the
> generic function.
>
> This patch adds the extra argument to generic functions and removes
> such wrappers when they are no more needed. This also fixes a
> compiler warning for sta2x11-fixup.c, that would have required yet
> another wrapper.
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> arch/ia64/kernel/pci-swiotlb.c | 11 ++---------
> arch/mips/cavium-octeon/dma-octeon.c | 4 ++--
> arch/unicore32/mm/dma-swiotlb.c | 22 ++--------------------
> arch/x86/kernel/pci-swiotlb.c | 11 ++---------
> arch/x86/pci/sta2x11-fixup.c | 3 ++-
> include/linux/swiotlb.h | 7 ++++---
> lib/swiotlb.c | 5 +++--
So .. what is this based on? I see in mainline alloc_coherent and free_coherent
which are obviously changed here.
Don't you also need to change these two files:
arch/x86/xen/pci-swiotlb-xen.c
drivers/xen/swiotlb-xen.c
next prev parent reply other threads:[~2012-05-24 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 11:44 [PATCH] swiotlb: add "dma_attrs" argument to alloc and free, to match dma_map_ops Alessandro Rubini
2012-05-24 15:15 ` David Daney
2012-05-24 17:47 ` Konrad Rzeszutek Wilk [this message]
2012-05-24 18:53 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524174741.GG24934@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=fenghua.yu@intel.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=giancarlo.asnaghi@st.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=kyungmin.park@samsung.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rubini@gnudd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox