From: Kent Overstreet <koverstreet@google.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
tj@kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de,
drbd-dev@lists.linbit.com, vgoyal@redhat.com,
mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net
Subject: Re: [PATCH v2 09/14] block: Add an explicit bio flag for bios that own their bvec
Date: Thu, 24 May 2012 14:31:58 -0700 [thread overview]
Message-ID: <20120524213158.GB22664@google.com> (raw)
In-Reply-To: <4FBE687E.1030605@panasas.com>
On Thu, May 24, 2012 at 07:57:34PM +0300, Boaz Harrosh wrote:
> How do you insure that the original bio which owns the
> bvec is not freed before the split-out bio.
>
> Perhaps calling code needs to make sure by taking an extra
> ref on the original bio, or something. If so a big fat comment
> at bio_split is do.
Yeah, just added that.
>
> And I understand you did not like my suggestion of negating
> the meaning of the flag, so the default is zero?
> Please say why?
I liked it at first, but I think I prefer having the flag be set
if bio_free() must take some action; i.e. you set the flag when you
allocate bi_io_vec. Also, I think bio_alloc_bioset() getting
reimplemented is less likely than people open coding bio splitting or
something that shares bi_io_vec in the future, so it's slightlry less
likely to be used wrong this way.
next prev parent reply other threads:[~2012-05-24 21:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 0:02 [PATCH v2 00/14] Block cleanups (for bcache) Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 01/14] block: Generalized bio pool freeing Kent Overstreet
2012-05-24 16:09 ` Tejun Heo
2012-05-24 16:19 ` Tejun Heo
2012-05-24 17:46 ` Vivek Goyal
2012-05-24 18:06 ` Boaz Harrosh
2012-05-24 0:02 ` [PATCH v2 02/14] dm: kill dm_rq_bio_destructor Kent Overstreet
2012-05-24 0:19 ` [dm-devel] " Jun'ichi Nomura
2012-05-24 0:39 ` Kent Overstreet
2012-05-24 1:16 ` Jun'ichi Nomura
2012-05-24 1:39 ` Jun'ichi Nomura
2012-05-24 23:33 ` Kent Overstreet
2012-05-24 16:11 ` Tejun Heo
2012-05-24 0:02 ` [PATCH v2 03/14] block: Add bio_clone_bioset() Kent Overstreet
2012-05-24 16:38 ` Tejun Heo
2012-05-24 18:45 ` Vivek Goyal
2012-05-24 23:35 ` Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 04/14] block: Add bio_clone_kmalloc() Kent Overstreet
2012-05-24 18:59 ` Vivek Goyal
2012-05-24 21:41 ` Yehuda Sadeh
2012-05-25 0:31 ` Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 05/14] block: Only clone bio vecs that are in use Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 06/14] block: Add bio_reset() Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 07/14] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-05-24 19:42 ` Vivek Goyal
2012-05-24 19:55 ` Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 08/14] block: Kill bi_destructor Kent Overstreet
2012-05-24 19:52 ` Vivek Goyal
2012-05-24 19:58 ` [dm-devel] " Vivek Goyal
2012-05-24 20:00 ` Kent Overstreet
2012-05-25 6:43 ` Boaz Harrosh
2012-05-24 0:02 ` [PATCH v2 09/14] block: Add an explicit bio flag for bios that own their bvec Kent Overstreet
2012-05-24 16:57 ` Boaz Harrosh
2012-05-24 21:31 ` Kent Overstreet [this message]
2012-05-25 16:49 ` Vivek Goyal
2012-05-25 20:01 ` Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 10/14] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 11/14] block: Rework bio splitting Kent Overstreet
2012-05-24 16:56 ` Boaz Harrosh
2012-05-24 21:27 ` Kent Overstreet
2012-05-25 18:48 ` Vivek Goyal
2012-05-24 0:02 ` [PATCH v2 12/14] Closures Kent Overstreet
2012-05-24 0:47 ` Joe Perches
2012-05-24 1:16 ` Kent Overstreet
2012-05-24 1:23 ` Joe Perches
2012-05-25 22:54 ` Andi Kleen
2012-05-24 0:02 ` [PATCH v2 13/14] Make generic_make_request handle arbitrarily large bios Kent Overstreet
2012-05-24 0:02 ` [PATCH v2 14/14] Gut bio_add_page() Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524213158.GB22664@google.com \
--to=koverstreet@google.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=neilb@suse.de \
--cc=sage@newdream.net \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
--cc=yehuda@hq.newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox