From: Greg KH <gregkh@linuxfoundation.org>
To: Jarkko Sakkinen <jarkko.sakkinen@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@linux.intel.com>,
Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
Subject: Re: [PATCH] x86, realmode: 16-bit real-mode code support for relocs tool
Date: Fri, 25 May 2012 15:05:42 +0900 [thread overview]
Message-ID: <20120525060542.GA28472@kroah.com> (raw)
In-Reply-To: <1337924683-16189-1-git-send-email-jarkko.sakkinen@intel.com>
On Fri, May 25, 2012 at 08:44:43AM +0300, Jarkko Sakkinen wrote:
> From: "H. Peter Anvin" <hpa@linux.intel.com>
>
> A new option is added to the relocs tool called '--realmode'.
> This option causes the generation of 16-bit segment relocations
> and 32-bit linear relocations for the real-mode code. When
> the real-mode code is moved to the low-memory during kernel
> initialization, these relocation entries can be used to
> relocate the code properly.
>
> In the assembly code 16-bit segment relocations must be relative
> to the 'real_mode_seg' absolute symbol. Linear relocations must be
> relative to a symbol prefixed with 'pa_'.
>
> 16-bit segment relocation is used to load cs:ip in 16-bit code.
> Linear relocations are used in the 32-bit code for relocatable
> data references. They are declared in the linker script of the
> real-mode code.
>
> The relocs tool is moved to arch/x86/tools/relocs.c, and added new
> target archscripts that can be used to build scripts needed building
> an architecture. be compiled before building the arch/x86 tree.
>
> [ hpa: accelerating this because it detects invalid absolute
> relocations, a serious bug in binutils 2.22.52.0.x which currently
> produces bad kernels. ]
>
> [ jsakkine: pulled tools/include/tools/le_byteshift.h in order
> to make this patch compile in 3.3 ]
Nope, your patch still doesn't apply, are you sure you sent me the
updated one? It fails with:
patching file arch/x86/boot/compressed/Makefile
Hunk #1 succeeded at 40 (offset 1 line).
patching file arch/x86/boot/compressed/relocs.c
Hunk #1 FAILED at 1.
File arch/x86/boot/compressed/relocs.c is not empty after patch, as expected
1 out of 1 hunk FAILED -- rejects in file arch/x86/boot/compressed/relocs.c
when applying it to the 3.3-stable queue.
What did you generate it against?
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-25 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 5:44 [PATCH] x86, realmode: 16-bit real-mode code support for relocs tool Jarkko Sakkinen
2012-05-25 6:05 ` Greg KH [this message]
2012-05-25 11:20 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2012-05-25 11:18 Jarkko Sakkinen
2012-05-26 23:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525060542.GA28472@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@iki.fi \
--cc=jarkko.sakkinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox