From: Dan Williams <dan.j.williams@intel.com>
To: mroos@linux.ee
Cc: linux-kernel@vger.kernel.org, JBottomley@parallels.com,
linux-scsi@vger.kernel.org
Subject: [RFT PATCH 0/4] fix / cleanup async scsi scanning
Date: Fri, 25 May 2012 00:50:22 -0700 [thread overview]
Message-ID: <20120525074813.21933.91876.stgit@dwillia2-linux.jf.intel.com> (raw)
Commit a7a20d10 "[SCSI] sd: limit the scope of the async probe domain"
introduces a boot regression by moving sd probe work off of the global
async queue. Using a local async domain hides the probe work from being
synchronized by wait_for_device_probe()->async_synchronize_full().
Fix this by teaching async_synchronize_full() to flush all async work
regardless of domain, and take the opportunity to convert scsi scanning
to async_schedule(). This enables wait_for_device_probe() to flush scsi
scanning work.
Lightly boot tested, Meelis does this fix your regression?
Thanks for your help.
--
Dan
---
Dan Williams (4):
async: introduce 'async_domain' type
async: make async_synchronize_full() flush all work regardless of domain
scsi: queue async scan work to an async_schedule domain
scsi: cleanup usages of scsi_complete_async_scans
drivers/regulator/core.c | 2 +-
drivers/scsi/libsas/sas_ata.c | 2 +-
drivers/scsi/scsi.c | 3 ++-
drivers/scsi/scsi_priv.h | 3 ++-
drivers/scsi/scsi_scan.c | 24 ++++++------------------
drivers/scsi/scsi_wait_scan.c | 15 +++++----------
include/linux/async.h | 20 ++++++++++++++++----
include/scsi/scsi_scan.h | 11 -----------
kernel/async.c | 36 ++++++++++++++++++++----------------
kernel/power/hibernate.c | 8 --------
kernel/power/user.c | 2 --
11 files changed, 53 insertions(+), 73 deletions(-)
delete mode 100644 include/scsi/scsi_scan.h
next reply other threads:[~2012-05-25 7:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 7:50 Dan Williams [this message]
2012-05-25 7:50 ` [PATCH 1/4] async: introduce 'async_domain' type Dan Williams
2012-05-25 7:51 ` James Bottomley
2012-05-25 8:18 ` Dan Williams
2012-05-25 8:48 ` James Bottomley
2012-05-25 19:23 ` Rafael J. Wysocki
2012-05-25 13:31 ` Arjan van de Ven
2012-05-25 13:40 ` mroos
2012-05-25 15:05 ` Dan Williams
2012-05-27 22:34 ` Mark Brown
2012-05-25 7:50 ` [PATCH 2/4] async: make async_synchronize_full() flush all work regardless of domain Dan Williams
2012-05-25 7:50 ` [PATCH 3/4] scsi: queue async scan work to an async_schedule domain Dan Williams
2012-05-25 7:50 ` [PATCH 4/4] scsi: cleanup usages of scsi_complete_async_scans Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525074813.21933.91876.stgit@dwillia2-linux.jf.intel.com \
--to=dan.j.williams@intel.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).