From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command
Date: Fri, 25 May 2012 14:43:59 +0100 [thread overview]
Message-ID: <20120525144359.712cb21d@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1337942353-30979-1-git-send-email-will.deacon@arm.com>
On Fri, 25 May 2012 11:39:13 +0100
Will Deacon <will.deacon@arm.com> wrote:
> As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error
> handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl
> command which they don't understand. Doing so will result in -ENOTTY
> being returned to userspace, which matches the behaviour of the compat
> layer if it fails to translate an ioctl command.
>
> This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of
> -EINVAL when passed an unknown ioctl command.
>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2012-05-25 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 10:39 [PATCH] pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command Will Deacon
2012-05-25 13:43 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525144359.712cb21d@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox