From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: acme@redhat.com, khandual@linux.vnet.ibm.com,
peterz@infradead.org, mingo@elte.hu
Subject: [PATCH] perf record: fix branch_stack type in perf_record_opts
Date: Fri, 25 May 2012 23:13:44 +0200 [thread overview]
Message-ID: <20120525211344.GA7729@quad> (raw)
The attr.branch_sample_type field is defined as u64 by the API.
As such, we need to ensure the variable holding the value of the
branch stack filters is also u64 otherwise we may lose bits in
the future.
Note also that the bogus definition of the field in
perf_record_opts caused problems on big-endian PPC systems.
Thanks to Anshuman Khandual for tracking the problem on PPC.
Signed-off-by: Stephane Eranian <eranian@google.com>
---
diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index 14f1034..f960ccb 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -227,7 +227,7 @@ struct perf_record_opts {
unsigned int freq;
unsigned int mmap_pages;
unsigned int user_freq;
- int branch_stack;
+ u64 branch_stack;
u64 default_interval;
u64 user_interval;
};
next reply other threads:[~2012-05-25 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 21:13 Stephane Eranian [this message]
2012-05-28 15:10 ` [PATCH] perf record: fix branch_stack type in perf_record_opts Anshuman Khandual
2012-05-30 7:47 ` [tip:perf/urgent] perf record: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525211344.GA7729@quad \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox