From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384Ab2EZNMW (ORCPT ); Sat, 26 May 2012 09:12:22 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33279 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578Ab2EZNMN (ORCPT ); Sat, 26 May 2012 09:12:13 -0400 From: Grant Likely Subject: Re: [PATCH v4 3/6] of: release node fix for of_parse_phandle_with_args To: Dong Aisheng , linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linus.walleij@stericsson.com, swarren@wwwdotorg.org, devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com, b29396@freescale.com In-Reply-To: <1337952980-14621-3-git-send-email-b29396@freescale.com> References: <1337952980-14621-1-git-send-email-b29396@freescale.com> <1337952980-14621-3-git-send-email-b29396@freescale.com> Date: Fri, 25 May 2012 18:09:57 -0600 Message-Id: <20120526000957.ED6BD3E13EF@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 May 2012 21:36:17 +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Since this API requires user to call of_node_put for the node > it returned via outargs, if no outargs provided, user have no > chance to release it, so release it internally if no outargs > provided. > > Signed-off-by: Dong Aisheng Applied, thanks. g. > --- > drivers/of/base.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index d9bfd49..91c1fb4 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -961,6 +961,8 @@ int of_parse_phandle_with_args(struct device_node *np, const char *list_name, > out_args->args_count = count; > for (i = 0; i < count; i++) > out_args->args[i] = be32_to_cpup(list++); > + } else { > + of_node_put(node); > } > return 0; > } > -- > 1.7.0.4 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.