From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tool: Add modifiers to be part of the event name
Date: Sat, 26 May 2012 00:15:56 -0300 [thread overview]
Message-ID: <20120526031556.GE6344@infradead.org> (raw)
In-Reply-To: <20120525223528.GK27374@one.firstfloor.org>
Em Sat, May 26, 2012 at 12:35:28AM +0200, Andi Kleen escreveu:
> On Fri, May 11, 2012 at 12:25:22PM +0200, Jiri Olsa wrote:
> > On Thu, May 10, 2012 at 05:17:48PM -0700, Andi Kleen wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > We need to save the original string for perf stat output,
> > > otherwise :t and :c are invisible.
> >
> > right, the modifier got lost
> >
> > We need to fix the name once modifier is detected and final
> > event name is assigned (e.g. there could be "*?" in the tracepoint
> > event name, causing the name to be unwinded..).
>
> What happened to this patch? Seems to be still broken in 3.4
The latest patchset I submitted should fix this for raw and hardware
events.
Saving the events specified by the user is not sufficient, as those
strings are not saved in perf.data files, we must reconstruct the
strings from what is stored in the perf_event_attr fields.
- Arnaldo
prev parent reply other threads:[~2012-05-26 3:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 0:17 [PATCH] perf, utils: Print the original modifiers in event_name Andi Kleen
2012-05-11 10:25 ` [PATCH] perf, tool: Add modifiers to be part of the event name Jiri Olsa
2012-05-14 23:55 ` Andi Kleen
2012-05-15 11:54 ` Jiri Olsa
2012-05-25 22:35 ` Andi Kleen
2012-05-26 3:15 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120526031556.GE6344@infradead.org \
--to=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox