From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools libtraceevent: Silence compiler warning on 32bit build
Date: Sat, 26 May 2012 14:16:50 -0300 [thread overview]
Message-ID: <20120526171650.GL2336@infradead.org> (raw)
In-Reply-To: <1338003691-3141-1-git-send-email-namhyung@gmail.com>
Em Sat, May 26, 2012 at 12:41:31PM +0900, Namhyung Kim escreveu:
> The gcc complains about casting a pointer to unsigned long long directly:
>
> SUBDIR ../lib/traceevent/
> CC FPIC event-parse.o
> CC FPIC trace-seq.o
> CC FPIC parse-filter.o
> /home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c: In function ‘get_value’:
> /home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c:1588: warning: cast from pointer to integer of different size
> CC FPIC parse-utils.o
> BUILD STATIC LIB libtraceevent.a
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> tools/lib/traceevent/parse-filter.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
> index 2d40c5e..aa30b43 100644
> --- a/tools/lib/traceevent/parse-filter.c
> +++ b/tools/lib/traceevent/parse-filter.c
> @@ -1585,7 +1585,7 @@ get_value(struct event_format *event,
> const char *name;
>
> name = get_comm(event, record);
> - return (unsigned long long)name;
> + return (unsigned long)name;
Thanks, applied to my perf/urgent branch,
- Arnaldo
next prev parent reply other threads:[~2012-05-26 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 3:41 [PATCH] tools libtraceevent: Silence compiler warning on 32bit build Namhyung Kim
2012-05-26 17:16 ` Arnaldo Carvalho de Melo [this message]
2012-05-30 7:48 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120526171650.GL2336@infradead.org \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox