From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907Ab2E2VWh (ORCPT ); Tue, 29 May 2012 17:22:37 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:59969 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754792Ab2E2VWg (ORCPT ); Tue, 29 May 2012 17:22:36 -0400 Date: Tue, 29 May 2012 17:22:29 -0400 (EDT) Message-Id: <20120529.172229.277102319861990758.davem@davemloft.net> To: florian@openwrt.org Cc: devendra.aaru@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] r6040: disable pci device if the subsequent calls (after pci_enable_device) fails From: David Miller In-Reply-To: <1659482.3g1Zl6FDuM@flexo> References: <1338206223-26781-1-git-send-email-devendra.aaru@gmail.com> <1659482.3g1Zl6FDuM@flexo> X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Tue, 29 May 2012 14:22:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Tue, 29 May 2012 11:20:50 +0200 > On Monday 28 May 2012 17:27:03 Devendra Naga wrote: >> the calls after the pci_enable_device may fail, and will error out with out >> disabling it. disable the device at error paths. > > Looks good, thanks Devendra! > >> >> Signed-off-by: Devendra Naga > > Acked-by: Florian Fainelli Applied.