From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dimitrios Semitsoglou-Tsiapos <dimitrios.semitsoglou@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding style errors and an if-statement
Date: Tue, 29 May 2012 09:29:55 +0300 [thread overview]
Message-ID: <20120529062955.GB21008@mwanda> (raw)
In-Reply-To: <1338229715-2730-1-git-send-email-dimitrios.semitsoglou@gmail.com>
On Mon, May 28, 2012 at 09:28:35PM +0300, Dimitrios Semitsoglou-Tsiapos wrote:
> Fixed a few coding style errors and an if-statement responsible for a
> sanity check inside the prep_ao_dma function.
>
I the change to the if statement is correct but it needs to be
resent in it's own patch. We want the fix to be noticeable in the
change log. Don't mix code changes and cleanups.
regards,
dan carpenter
prev parent reply other threads:[~2012-05-29 6:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 18:28 [PATCH] staging: comedi: cb_pcidas64: Fixed coding style errors and an if-statement Dimitrios Semitsoglou-Tsiapos
2012-05-28 19:31 ` richard -rw- weinberger
2012-05-28 21:51 ` [PATCH 1/2] staging: comedi: cb_pcidas64: Fixed coding style errors Dimitrios Semitsoglou-Tsiapos
2012-05-28 21:51 ` [PATCH 2/2] staging: comedi: cb_pcidas64: Fixed an if-statement check Dimitrios Semitsoglou-Tsiapos
2012-06-05 3:43 ` Greg KH
2012-06-05 8:17 ` Dimitrios Semitsoglou-Tsiapos
2012-06-05 8:31 ` Dan Carpenter
2012-05-29 6:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529062955.GB21008@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dimitrios.semitsoglou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox