From: Yong Zhang <yong.zhang0@gmail.com>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, sshtylyov@mvista.com,
david.daney@cavium.com,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
axboe@kernel.dk, jeremy.fitzhardinge@citrix.com,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled
Date: Tue, 29 May 2012 14:52:48 +0800 [thread overview]
Message-ID: <20120529065248.GA2597@zhy> (raw)
In-Reply-To: <4FC369E3.1030901@linux.vnet.ibm.com>
On Mon, May 28, 2012 at 05:34:51PM +0530, Srivatsa S. Bhat wrote:
> No, I think you are right. Sorry for the delay in replying.
> It indeed looks like we need not use ipi_call_lock/unlock() in CPU bringup
> code..
>
> However, it does make me wonder about this:
> commit 3d4422332 introduced the generic ipi helpers, and reduced the scope
> of call_function.lock and also added the check in
> generic_smp_call_function_interrupt() to proceed only if the cpu is present
> in data->cpumask.
>
> Then, commit 3b16cf8748 converted x86 to the generic ipi helpers, but while
> doing that, it explicitly retained ipi_call_lock/unlock(), which is kind of
> surprising.. I guess it was a mistake rather than intentional.
Agree. I think it's a mistake(or leftover) too :)
Anyway, let me cook a patch to throw a stone to clear the road.
Thanks,
Yong
next prev parent reply other threads:[~2012-05-29 6:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 6:00 [V1 PATCH 0/8] patchset focus on MIPS SMP woes Yong Zhang
2012-05-21 6:00 ` [PATCH 1/8] MIPS: Octeon: delay enable irq to ->smp_finish() Yong Zhang
2012-05-21 6:00 ` [PATCH 2/8] MIPS: BMIPS: delay irq enable " Yong Zhang
2012-05-21 6:00 ` [PATCH 3/8] MIPS: SMTC: " Yong Zhang
2012-05-21 6:00 ` [PATCH 4/8] MIPS: Yosemite: " Yong Zhang
2012-05-21 6:00 ` [PATCH 5/8] MIPS: call ->smp_finish() a little late Yong Zhang
2012-05-21 6:00 ` [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled Yong Zhang
2012-05-21 10:30 ` Sergei Shtylyov
2012-05-22 5:33 ` Yong Zhang
2012-05-21 10:39 ` Srivatsa S. Bhat
2012-05-22 6:21 ` Yong Zhang
2012-05-28 12:04 ` Srivatsa S. Bhat
2012-05-29 6:52 ` Yong Zhang [this message]
2012-05-21 6:00 ` [PATCH 7/8] MIPS: smp: Warn on too early irq enable Yong Zhang
2012-05-21 6:00 ` [PATCH 8/8] MIPS: sync-r4k: remove redundant irq operation Yong Zhang
-- strict thread matches above, loose matches on Subject: below --
2012-05-17 10:10 [PATCH 0/8] patchset focus on MIPS SMP woes Yong Zhang
2012-05-17 10:10 ` [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled Yong Zhang
2012-05-17 10:59 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529065248.GA2597@zhy \
--to=yong.zhang0@gmail.com \
--cc=axboe@kernel.dk \
--cc=david.daney@cavium.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@kernel.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ralf@linux-mips.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=sshtylyov@mvista.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox