Re: [RFC PATCH -tip 8/9] kprobes: introduce ftrace based optiomization

[Ananth N Mavinakayanahalli <ananth@in.ibm.com>]

On Tue, May 29, 2012 at 09:49:45PM +0900, Masami Hiramatsu wrote:
> Introduce function trace based kprobes optimization.
> 
> With using ftrace optimization, kprobes on the mcount calling
> address, use ftrace's mcount call instead of breakpoint.
> Farthermore, this optimization works with preemptive kernel
> not like as current jump-based optimization. Of cource,
> this feature is limited only if the probe on mcount call.

The above paragraph doesn't parse correctly for me. Do you mean to say
if the probe is on the mcount calling address, use the jump based
approach instead of the breakpoint one? Could you please rephrase?

...

> +static void __kprobes kprobe_ftrace_init(void)
> +{
> +	int ret;
> +
> +	ret = register_ftrace_function(&kprobe_ftrace_ops);
> +	WARN(ret < 0, "Failed to init kprobe-ftrace (%d)\n", ret);
> +
> +	kprobe_ftrace_enabled = 1;

Hmm.. is this right? kprobe_ftrace_enabled is 1 even if the init failed.

Ananth