From: Ingo Molnar <mingo@kernel.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Don Zickus <dzickus@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]x86, reboot: Fix a warning message triggered by stop_other_cpus()
Date: Wed, 30 May 2012 10:51:10 +0200 [thread overview]
Message-ID: <20120530085110.GA18592@gmail.com> (raw)
In-Reply-To: <20120528092209.60677c3b@feng-i7>
* Feng Tang <feng.tang@intel.com> wrote:
> Hi Don,
>
> On Tue, 22 May 2012 09:33:56 -0400
> Don Zickus <dzickus@redhat.com> wrote:
>
> > On Tue, May 22, 2012 at 10:52:33AM +0800, Feng Tang wrote:
> > >
> > > The root cause seems to be the default_send_IPI_mask_allbutself_phys()
> > > takes quiet some time (I measured it could be several ms) to complete
> > > sending NMIs to all the other 23 CPUs, and for HZ=250/1000 system, the
> >
> > I sent Ingo a patch (which he took in), that reverts this path to interrupts
> > again (and NMIs as a fallback if it fails). The problem will still exist
> > I assume though I don't know if it changes the timing characteristics.
>
> Thanks for your review and letting me know the revert which I just saw in
> the latest Linus' tree. And I think this new mechanism will greatly reduce
> the possibility, but it still exist as the old nmi_stop_other_cpus's
> implementation still exist. So
>
> Ingo,
>
> Could you review this patch? thanks,
It doesn't apply anymore, so please merge and add Don's
Acked-by.
Thanks,
Ingo
next prev parent reply other threads:[~2012-05-30 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 2:52 [PATCH]x86, reboot: Fix a warning message triggered by stop_other_cpus() Feng Tang
2012-05-22 13:33 ` Don Zickus
2012-05-28 1:22 ` Feng Tang
2012-05-30 8:51 ` Ingo Molnar [this message]
2012-05-30 15:15 ` Feng Tang
2012-06-06 15:19 ` [tip:x86/urgent] x86/reboot: " tip-bot for Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530085110.GA18592@gmail.com \
--to=mingo@kernel.org \
--cc=dzickus@redhat.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).