From: Serge Hallyn <serge.hallyn@canonical.com>
To: Kees Cook <keescook@chromium.org>
Cc: Sasikantha babu <sasikanth.v19@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
James Morris <james.l.morris@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] prctl: Removed redunant assignment of "error" to zero
Date: Wed, 30 May 2012 13:28:35 -0500 [thread overview]
Message-ID: <20120530182835.GA12122@amd1> (raw)
In-Reply-To: <CAGXu5jKM1NH0mgfuCvR38Cs9quhV6m8dYsWd+ZY1QMzsyAkjyA@mail.gmail.com>
Quoting Kees Cook (keescook@chromium.org):
> On Wed, May 30, 2012 at 8:27 AM, Sasikantha babu
> <sasikanth.v19@gmail.com> wrote:
> > Just setting the "error" to error number is enough on failure and
> > It doesn't require to set "error" variable to zero in each switch case, since
> > it was already initialized with zero. And also removed return 0 in switch case
> > with break statement
> >
> > Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
>
> Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Serge E. Hallyn <serge@hallyn.com>
>
> -Kees
>
> --
> Kees Cook
> Chrome OS Security
prev parent reply other threads:[~2012-05-30 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 15:27 [PATCH v2] prctl: Removed redunant assignment of "error" to zero Sasikantha babu
2012-05-30 17:53 ` Kees Cook
2012-05-30 18:28 ` Serge Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530182835.GA12122@amd1 \
--to=serge.hallyn@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasikanth.v19@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox