* checkpatch: False positive on wrong indentation within block.
@ 2012-05-31 10:54 Kamalesh Babulal
0 siblings, 0 replies; only message in thread
From: Kamalesh Babulal @ 2012-05-31 10:54 UTC (permalink / raw)
To: linux-kernel; +Cc: apw
Checkpatch does not warns about the wrong indentation within a block.
When checkpatch is run on following patch, it does not complain about
the wrong indentation of if block.
[...]
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index fd019d7..a8d78f3 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -382,7 +382,12 @@ void __cpuinit set_cpu_sibling_map(int cpu)
if ((i == cpu) || (has_mc && match_llc(c, o)))
link_mask(llc_shared, cpu, i);
- if ((i == cpu) || (has_mc && match_mc(c, o))) {
+ }
+
+ for_each_cpu(i, cpu_sibling_setup_mask) {
+ o = &cpu_data(i);
+
+ if ((i == cpu) || (has_mc && match_mc(c, o))) {
link_mask(core, cpu, i);
/*
$ ./scripts/checkpatch.pl Fix-booted_cores-reporting.patch
total: 0 errors, 0 warnings, 13 lines checked
Fix-booted_cores-reporting.patch has no obvious style problems and is ready for submission.
Thanks,
Kamalesh.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-31 11:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-31 10:54 checkpatch: False positive on wrong indentation within block Kamalesh Babulal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox