From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jonghwa3.lee@samsung.com
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Yadwinder Singh Brar <yadi.brar01@gmail.com>,
Chiwoong Byun <woong.byun@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v5] regulator: MAX77686: Add Maxim 77686 regulator driver
Date: Thu, 31 May 2012 13:47:58 +0100 [thread overview]
Message-ID: <20120531124758.GE2666@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FC71161.9010002@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On Thu, May 31, 2012 at 03:36:17PM +0900, jonghwa3.lee@samsung.com wrote:
> On 2012년 05월 31일 02:26, Mark Brown wrote:
> > On Tue, May 29, 2012 at 11:20:51AM +0900, Jonghwa Lee wrote:
> >> +#ifdef CONFIG_COMMON_CLK
> >> + struct clk clk32khz_ap;
> >> + struct clk clk32khz_cp;
> >> + struct clk clk32khz_pmic;
> >> +#endif
> > This should be a clock driver in drivers/clock.
> Isn't it drivers/clk ? Could you explain more about this?
It's using the drivers/clk API, yes - what I'm saying is that you should
make a new MFD child driver drivers/clk/clk-max77686.c (or whatever) to
contain this code.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-31 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 2:20 [PATCH v5] regulator: MAX77686: Add Maxim 77686 regulator driver Jonghwa Lee
2012-05-30 17:26 ` Mark Brown
2012-05-31 6:36 ` jonghwa3.lee
2012-05-31 12:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531124758.GE2666@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=myungjoo.ham@samsung.com \
--cc=woong.byun@samsung.com \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).