From: Oliver Neukum <oneukum@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Stefani Seibold <stefani@seibold.net>,
linux-kernel@vger.kernel.org,
thomas.braunstorfinger@rohde-schwarz.com
Subject: Re: [PATCH] add new NRP power meter USB device driver
Date: Fri, 1 Jun 2012 15:38:41 +0200 [thread overview]
Message-ID: <201206011538.41910.oneukum@suse.de> (raw)
In-Reply-To: <20120531143255.GA7069@kroah.com>
Am Donnerstag, 31. Mai 2012, 16:32:55 schrieb Greg KH:
> On Thu, May 31, 2012 at 04:22:31PM +0200, Oliver Neukum wrote:
> > It seems to specialised for this kind of IO. SPI over USB is closer to a generic
> > thing rather like sg or even a bus rather than an IIO device. Kernel space drivers
> > that use SPI might belong into IIO. The infrastructure itself not so much.
>
> Wait, are you talking about the SPI we already support in the kernel?
Damn, one should watch one's spelling. SPI != SCPI
In the kernel we have SPI. This proposed driver is for SCPI.
The only relation they have is phonetic.
> Or something else? This driver really looks like it wants to send to
> userspace "measurements" of something, which IIO is for.
As far as I can tell, it works by messages over a bus, rather like SCSI.
>
> Anyway, as-is, this isn't acceptable, I'm sure we can all agree on that
> :)
Well, apart from the only ioctl I've seen far worse drivers.
The issue is not the driver as such, but whether and it what form it should exist.
Regards
Oliver
next prev parent reply other threads:[~2012-06-01 13:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 19:14 [PATCH] add new NRP power meter USB device driver stefani
2012-05-29 23:15 ` Greg KH
2012-05-31 8:47 ` Stefani Seibold
2012-05-31 9:41 ` Greg KH
2012-06-02 7:10 ` Stefani Seibold
2012-06-02 12:10 ` Greg KH
2012-06-02 15:43 ` Stefani Seibold
2012-05-31 9:53 ` Greg KH
2012-05-31 10:17 ` Oliver Neukum
2012-05-31 12:04 ` Greg KH
2012-05-31 12:32 ` Oliver Neukum
2012-05-31 12:48 ` Greg KH
2012-05-31 14:22 ` Oliver Neukum
2012-05-31 14:32 ` Greg KH
2012-06-01 13:38 ` Oliver Neukum [this message]
2012-05-30 8:10 ` Oliver Neukum
2012-05-31 7:43 ` Stefani Seibold
2012-05-31 8:20 ` Oliver Neukum
2012-05-31 9:21 ` Stefani Seibold
2012-06-01 14:16 ` Oliver Neukum
2012-06-01 14:34 ` Alan Cox
2012-06-02 5:57 ` Stefani Seibold
-- strict thread matches above, loose matches on Subject: below --
2012-06-02 16:18 stefani
2012-06-02 20:24 ` Oliver Neukum
2012-06-03 5:15 ` Stefani Seibold
2012-06-03 8:46 stefani
2012-06-03 11:48 ` Joe Perches
2012-06-13 0:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206011538.41910.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=thomas.braunstorfinger@rohde-schwarz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox