From: Oleg Nesterov <oleg@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Anton Arapov <anton@redhat.com>
Subject: Re: [RESEND PATCH 1/3] uprobes: Remove redundant lock_page/unlock_page
Date: Fri, 1 Jun 2012 20:52:37 +0200 [thread overview]
Message-ID: <20120601185237.GC31771@redhat.com> (raw)
In-Reply-To: <20120601091950.GF24279@linux.vnet.ibm.com>
On 06/01, Srikar Dronamraju wrote:
>
> @@ -315,12 +315,10 @@ static int read_opcode(struct mm_struct *mm, unsigned long vaddr, uprobe_opcode_
> if (ret <= 0)
> return ret;
>
> - lock_page(page);
> vaddr_new = kmap_atomic(page);
> vaddr &= ~PAGE_MASK;
> memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE);
> kunmap_atomic(vaddr_new);
> - unlock_page(page);
Great, this lock_page() was really confusing.
Oleg.
next prev parent reply other threads:[~2012-06-01 18:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 11:46 [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page Srikar Dronamraju
2012-05-31 11:46 ` [PATCH 2/3] perf/uprobes: Remove unnecessary check before strlist__delete Srikar Dronamraju
2012-06-06 7:08 ` [tip:perf/urgent] perf uprobes: " tip-bot for Srikar Dronamraju
2012-05-31 11:46 ` [PATCH 3/3] perf: Check for valid dso before creating map Srikar Dronamraju
2012-06-06 7:07 ` [tip:perf/urgent] perf symbols: " tip-bot for Srikar Dronamraju
2012-05-31 11:58 ` [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page Peter Zijlstra
2012-05-31 14:22 ` Steven Rostedt
2012-05-31 15:07 ` Srikar Dronamraju
2012-05-31 16:56 ` Peter Zijlstra
2012-05-31 16:58 ` Srikar Dronamraju
2012-06-01 9:19 ` [RESEND PATCH 1/3] uprobes: " Srikar Dronamraju
2012-06-01 18:52 ` Oleg Nesterov [this message]
2012-06-06 9:18 ` Ingo Molnar
2012-06-06 9:19 ` Peter Zijlstra
2012-08-06 11:57 ` Anton Arapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601185237.GC31771@redhat.com \
--to=oleg@redhat.com \
--cc=acme@infradead.org \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox