public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/wlan-ng: Fix the checkpatch warnings
Date: Mon, 4 Jun 2012 20:58:33 -0700	[thread overview]
Message-ID: <20120605035833.GA16700@kroah.com> (raw)
In-Reply-To: <1337520702-22961-1-git-send-email-devendra.aaru@gmail.com>

On Sun, May 20, 2012 at 07:01:42PM +0530, Devendra Naga wrote:
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c |   27 +++++++++++++++++++--------
>  1 file changed, 19 insertions(+), 8 deletions(-)


Ok, you sent me 5 patches, all with the same subject (except for 3 of
them you used x/3, which was nice, but you duplicated 3/3 for some
reason.)

I can't accept that, please be more specific in your subject: line.

Also, in the body, say exactly what checkpatch warnings you fixed, and,
if you fixed more than one type of warning, that might indicate that you
should break the patch up into different parts.

So, I've dropped all 5 patches you've sent me, please redo and resend.

thanks,

greg k-h

  reply	other threads:[~2012-06-05  6:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20 13:31 [PATCH] staging/wlan-ng: Fix the checkpatch warnings Devendra Naga
2012-06-05  3:58 ` Greg Kroah-Hartman [this message]
2012-06-05 10:23   ` devendra.aaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120605035833.GA16700@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devendra.aaru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox