From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Paul McKenney <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] driver core: fix shutdown races with probe/remove
Date: Tue, 5 Jun 2012 18:18:58 +0900 [thread overview]
Message-ID: <20120605091858.GA20917@kroah.com> (raw)
In-Reply-To: <1338886747-28088-1-git-send-email-ming.lei@canonical.com>
On Tue, Jun 05, 2012 at 04:59:07PM +0800, Ming Lei wrote:
> Firstly, .shutdown callback may touch a uninitialized hardware
> if dev->driver is set and .probe is not completed.
When would that ever happen?
> Secondly, device_shutdown() may dereference a null pointer to cause
> oops when dev->driver is cleared after it is checked in device_shutdown().
Again, when would that happen? A new device/driver being added to the
system as it is being shutdown?
Has anyone ever hit that before?
Is this really needed?
greg k-h
next prev parent reply other threads:[~2012-06-05 9:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 8:59 [PATCH] driver core: fix shutdown races with probe/remove Ming Lei
2012-06-05 9:18 ` Greg Kroah-Hartman [this message]
2012-06-05 9:38 ` Ming Lei
2012-06-05 14:47 ` Alan Stern
2012-06-05 15:17 ` Ming Lei
2012-06-05 17:09 ` Alan Stern
2012-06-05 20:21 ` Greg Kroah-Hartman
2012-06-05 20:44 ` Alan Stern
2012-06-06 2:27 ` Ming Lei
2012-06-06 13:42 ` Paul E. McKenney
2012-06-06 15:21 ` Alan Stern
2012-06-06 15:48 ` Paul E. McKenney
2012-06-06 16:05 ` Alan Stern
2012-06-06 16:24 ` Paul E. McKenney
2012-06-06 14:44 ` Alan Stern
2012-06-06 15:14 ` Paul E. McKenney
2012-06-06 15:44 ` Alan Stern
2012-06-06 15:55 ` Paul E. McKenney
2012-06-06 16:58 ` Alan Stern
2012-06-06 23:24 ` Paul E. McKenney
2012-06-07 9:30 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605091858.GA20917@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox