Re: [PATCH 0/8] Rework KERN_

Andrew Morton
2012-06-05T23:29:13Z

On Tue, 05 Jun 2012 15:49:32 -0700
Joe Perches <joe@perches.com> wrote:

> On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 15:11:43 -0700
> > Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote:
> > > > Unfortunately the <n> thing is part of the kernel ABI:
> > > >
> > > > echo "<4>foo" > /dev/kmsg
> > >
> > > Which works the same way it did before.
> >
> > I didn't say it didn't.
> >
> > What I did say is that echo "\0014">/dev/kmsg will subvert the intent
> > of the new logging code. Or might. But you just ignored all that,
> > forcing me to repeat myself, irritatedly.
>
> It works the same way before and after the patch.
>
> Any write to /dev/kmsg without a KERN_<LEVEL>
> emits at (1 << 3) + KERN_DEFAULT.
>
> Writes with <n> values >= 8 are emitted at
> that level.

What about writes starting with \001n? AFACIT, that will be stripped
away and the printk level will be altered. This is new behavior.