From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC] clean up headers for light drivers : backlights, leds and iio-light
Date: Wed, 6 Jun 2012 05:17:38 +0900 [thread overview]
Message-ID: <20120605201738.GC27297@kroah.com> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998FAD86@DQHE02.ent.ti.com>
On Tue, Jun 05, 2012 at 03:43:08PM +0000, Kim, Milo wrote:
> I'd like to suggest some clean up idea for headers under include/linux.
> Light device drivers are exist under 'drivers/leds' and 'drivers/video/backlight'.
> (and iio light drivers are ongoing in staging directory)
> At this moment, there is no specific directory for light driver, some headers are located in include/linux.
> Furthermore, new light drivers may be added into include/linux again and again.
Why do any of these need .h files in include/linux/ in the first place?
> So my suggestion is
>
> - create new directory for light driver : include/linux/light
> - move driver headers into this directory
> - change header declaration per each driver source
>
> Here is the cleanup list of light drivers.
>
> (leds and backlight)
> include/linux/apple_bl.h
> include/linux/atmel_pwm.h
> include/linux/backlight.h
> include/linux/led-lm3530.h
> include/linux/leds-bd2802.h
> include/linux/leds.h
> include/linux/leds-lm3556.h
> include/linux/leds-lp3944.h
> include/linux/leds-lp5521.h
> include/linux/leds-lp5523.h
> include/linux/leds-pca9532.h
> include/linux/leds_pwm.h
> include/linux/leds-regulator.h
> include/linux/leds-tca6507.h
> include/linux/lp855x.h
> include/linux/pwm_backlight.h
Lots of those can move to include/linux/platform_data/ today, which
would clean up things a lot. Care to do that first and see what is left
over and is really needed here?
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-05 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 15:43 [RFC] clean up headers for light drivers : backlights, leds and iio-light Kim, Milo
2012-06-05 20:17 ` gregkh [this message]
2012-06-06 4:49 ` Kim, Milo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605201738.GC27297@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Milo.Kim@ti.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox